Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) simplify decimal comparison wrong when cast to smaller scale #41151

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[fix](Nereids) simplify decimal comparison wrong when cast to smaller scale #41151

merged 1 commit into from
Sep 24, 2024

Conversation

morrySnow
Copy link
Contributor

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41515 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9f1746f405c13289fbda34bff89477d87e13aac7, data reload: false

------ Round 1 ----------------------------------
q1	17581	7366	7281	7281
q2	2010	289	290	289
q3	12271	1081	1206	1081
q4	10565	704	735	704
q5	7755	3133	3063	3063
q6	233	155	151	151
q7	1032	620	603	603
q8	9623	2052	2030	2030
q9	8162	6418	6388	6388
q10	7009	2270	2323	2270
q11	429	241	247	241
q12	405	219	221	219
q13	17783	2968	2943	2943
q14	237	209	218	209
q15	582	536	524	524
q16	704	622	622	622
q17	977	780	811	780
q18	7259	6641	6699	6641
q19	1399	1030	956	956
q20	568	281	276	276
q21	4016	3235	3328	3235
q22	1097	1009	1015	1009
Total cold run time: 111697 ms
Total hot run time: 41515 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7246	7276	7260	7260
q2	340	248	241	241
q3	3040	2970	2932	2932
q4	2073	1847	1758	1758
q5	5577	5594	5663	5594
q6	236	142	143	142
q7	2234	1802	1869	1802
q8	3319	3495	3468	3468
q9	8948	9002	8920	8920
q10	3524	3478	3461	3461
q11	573	473	479	473
q12	812	620	609	609
q13	9418	3156	3158	3156
q14	305	277	259	259
q15	570	529	516	516
q16	735	671	667	667
q17	1812	1619	1595	1595
q18	8209	7681	7749	7681
q19	1712	1562	1619	1562
q20	2082	1888	1882	1882
q21	5342	5314	5341	5314
q22	1167	1032	1073	1032
Total cold run time: 69274 ms
Total hot run time: 60324 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192072 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9f1746f405c13289fbda34bff89477d87e13aac7, data reload: false

query1	946	395	398	395
query2	6361	2053	1999	1999
query3	8695	197	205	197
query4	33645	23499	23274	23274
query5	3441	463	482	463
query6	262	163	166	163
query7	4194	295	298	295
query8	287	211	213	211
query9	9481	2659	2648	2648
query10	486	286	275	275
query11	17953	15296	15221	15221
query12	160	96	96	96
query13	1529	415	412	412
query14	9361	7150	7488	7150
query15	242	172	173	172
query16	8093	436	498	436
query17	1680	621	588	588
query18	2175	317	325	317
query19	372	176	159	159
query20	120	111	116	111
query21	216	107	109	107
query22	4807	4815	4441	4441
query23	35160	34389	34582	34389
query24	11115	3050	2922	2922
query25	595	412	417	412
query26	728	161	160	160
query27	2018	288	283	283
query28	6505	2452	2430	2430
query29	765	430	433	430
query30	266	156	154	154
query31	1027	796	785	785
query32	99	60	58	58
query33	655	317	300	300
query34	926	521	506	506
query35	849	731	731	731
query36	1120	935	955	935
query37	145	90	89	89
query38	4003	3864	3931	3864
query39	1462	1422	1415	1415
query40	209	96	98	96
query41	50	48	49	48
query42	118	98	94	94
query43	510	477	474	474
query44	1177	840	821	821
query45	195	165	163	163
query46	1147	805	773	773
query47	1924	1790	1828	1790
query48	475	365	379	365
query49	888	422	424	422
query50	819	427	415	415
query51	6943	7044	6871	6871
query52	101	90	90	90
query53	258	183	184	183
query54	1251	448	453	448
query55	80	78	77	77
query56	291	256	266	256
query57	1217	1131	1166	1131
query58	236	232	245	232
query59	3205	3228	3295	3228
query60	302	263	285	263
query61	102	102	105	102
query62	809	668	667	667
query63	216	192	186	186
query64	3580	669	636	636
query65	3248	3171	3176	3171
query66	754	297	297	297
query67	16271	15563	15812	15563
query68	4549	583	582	582
query69	569	296	301	296
query70	1228	1122	1130	1122
query71	401	277	287	277
query72	7805	4037	4141	4037
query73	774	333	343	333
query74	10444	9148	9058	9058
query75	4529	2710	2668	2668
query76	3529	1035	913	913
query77	729	296	293	293
query78	9998	9224	9585	9224
query79	2106	554	569	554
query80	1057	445	469	445
query81	560	242	240	240
query82	548	143	133	133
query83	373	131	133	131
query84	287	76	77	76
query85	1366	292	292	292
query86	443	290	293	290
query87	4426	4448	4337	4337
query88	3881	2344	2339	2339
query89	397	282	287	282
query90	2039	187	186	186
query91	180	143	139	139
query92	60	49	50	49
query93	1852	541	550	541
query94	1085	297	301	297
query95	351	257	265	257
query96	622	283	279	279
query97	3241	3063	3098	3063
query98	221	196	195	195
query99	1666	1316	1289	1289
Total cold run time: 299636 ms
Total hot run time: 192072 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9f1746f405c13289fbda34bff89477d87e13aac7, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.64	0.10	0.10
query5	0.52	0.51	0.51
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.55	0.50	0.49
query10	0.55	0.58	0.54
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.60	0.60	0.61
query14	2.97	2.91	3.04
query15	0.91	0.82	0.82
query16	0.38	0.40	0.40
query17	0.98	1.02	1.05
query18	0.20	0.19	0.19
query19	1.91	1.81	2.03
query20	0.01	0.01	0.01
query21	15.37	0.57	0.57
query22	2.70	3.96	1.52
query23	17.19	0.84	0.79
query24	3.12	0.88	0.43
query25	0.15	0.12	0.15
query26	0.51	0.14	0.13
query27	0.04	0.04	0.04
query28	11.05	1.10	1.06
query29	12.56	3.27	3.24
query30	0.25	0.06	0.06
query31	2.89	0.39	0.37
query32	3.26	0.48	0.45
query33	3.01	3.02	3.01
query34	17.26	4.35	4.40
query35	4.45	4.52	4.47
query36	0.67	0.49	0.47
query37	0.08	0.05	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.07	0.02	0.02
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.98 s
Total hot run time: 31.88 s

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40884 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 02daac32c362a90117b42c7bfd8b3d41a3d66e0b, data reload: false

------ Round 1 ----------------------------------
q1	17560	7597	7283	7283
q2	2013	285	285	285
q3	12303	1092	1139	1092
q4	10557	712	734	712
q5	7774	2907	2869	2869
q6	237	159	148	148
q7	991	611	611	611
q8	9551	1908	2011	1908
q9	7915	6449	6394	6394
q10	6993	2324	2345	2324
q11	437	245	244	244
q12	428	224	216	216
q13	17781	3017	2983	2983
q14	241	224	217	217
q15	571	527	524	524
q16	678	602	617	602
q17	982	587	526	526
q18	7215	6784	6617	6617
q19	1398	1103	944	944
q20	575	304	285	285
q21	4080	3285	3124	3124
q22	1105	976	1000	976
Total cold run time: 111385 ms
Total hot run time: 40884 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7296	7216	7241	7216
q2	345	248	243	243
q3	3037	3031	2973	2973
q4	2074	1786	1790	1786
q5	5718	5623	5837	5623
q6	233	145	143	143
q7	2188	1839	1884	1839
q8	3360	3533	3582	3533
q9	8988	8984	8941	8941
q10	3584	3572	3547	3547
q11	575	490	494	490
q12	799	603	614	603
q13	8437	3168	3205	3168
q14	306	293	263	263
q15	568	533	511	511
q16	736	662	657	657
q17	1892	1647	1610	1610
q18	8175	7884	7788	7788
q19	1702	1531	1430	1430
q20	2168	1876	1892	1876
q21	5630	5312	5323	5312
q22	1126	1043	1060	1043
Total cold run time: 68937 ms
Total hot run time: 60595 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193214 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 02daac32c362a90117b42c7bfd8b3d41a3d66e0b, data reload: false

query1	977	386	401	386
query2	6255	1990	2023	1990
query3	8685	194	200	194
query4	33574	23614	23500	23500
query5	3505	480	475	475
query6	274	190	165	165
query7	4193	306	299	299
query8	285	218	231	218
query9	9667	2733	2722	2722
query10	467	285	283	283
query11	18037	15204	15166	15166
query12	153	99	96	96
query13	1542	428	407	407
query14	9306	7697	7685	7685
query15	263	171	182	171
query16	8082	469	486	469
query17	1662	607	591	591
query18	2173	320	316	316
query19	359	156	162	156
query20	126	117	118	117
query21	217	109	106	106
query22	4634	4490	4598	4490
query23	36284	34552	34529	34529
query24	11181	3085	2934	2934
query25	580	401	420	401
query26	853	163	161	161
query27	2144	301	296	296
query28	7260	2472	2451	2451
query29	717	449	438	438
query30	260	158	167	158
query31	1051	780	783	780
query32	98	56	57	56
query33	762	301	306	301
query34	998	483	497	483
query35	902	727	742	727
query36	1128	940	948	940
query37	155	90	91	90
query38	4088	3955	3904	3904
query39	1492	1452	1429	1429
query40	205	100	101	100
query41	52	50	48	48
query42	124	99	98	98
query43	539	485	479	479
query44	1316	830	813	813
query45	194	165	167	165
query46	1234	742	750	742
query47	1932	1816	1847	1816
query48	470	391	390	390
query49	884	420	401	401
query50	889	412	407	407
query51	6977	6899	6890	6890
query52	103	89	90	89
query53	266	210	180	180
query54	1106	459	472	459
query55	81	74	77	74
query56	299	256	257	256
query57	1244	1067	1085	1067
query58	257	237	229	229
query59	3173	3161	2992	2992
query60	305	271	278	271
query61	108	110	105	105
query62	855	671	661	661
query63	218	186	184	184
query64	3889	635	651	635
query65	3262	3220	3244	3220
query66	718	306	308	306
query67	16063	15741	15650	15650
query68	4490	573	567	567
query69	597	294	316	294
query70	1153	1114	1126	1114
query71	414	274	276	274
query72	7718	4122	4154	4122
query73	829	349	350	349
query74	10476	9008	9139	9008
query75	4434	2668	2696	2668
query76	4207	978	910	910
query77	761	323	298	298
query78	10237	9148	9241	9148
query79	2053	599	602	599
query80	955	453	441	441
query81	579	242	242	242
query82	623	138	145	138
query83	392	142	139	139
query84	285	82	81	81
query85	1262	301	294	294
query86	376	311	298	298
query87	4405	4395	4375	4375
query88	3472	2406	2370	2370
query89	424	290	289	289
query90	2028	192	192	192
query91	183	146	140	140
query92	62	51	51	51
query93	1801	558	557	557
query94	881	311	307	307
query95	358	256	267	256
query96	670	290	289	289
query97	3277	3094	3141	3094
query98	217	197	200	197
query99	1554	1306	1308	1306
Total cold run time: 302325 ms
Total hot run time: 193214 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.89 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 02daac32c362a90117b42c7bfd8b3d41a3d66e0b, data reload: false

query1	0.05	0.04	0.05
query2	0.06	0.02	0.03
query3	0.23	0.07	0.07
query4	1.64	0.10	0.10
query5	0.52	0.51	0.53
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.03	0.03	0.03
query9	0.56	0.50	0.50
query10	0.55	0.56	0.56
query11	0.14	0.11	0.11
query12	0.14	0.10	0.11
query13	0.61	0.59	0.60
query14	2.96	2.96	3.00
query15	0.90	0.82	0.83
query16	0.36	0.38	0.39
query17	1.05	1.06	1.05
query18	0.20	0.20	0.19
query19	1.97	1.88	2.00
query20	0.02	0.01	0.01
query21	15.35	0.56	0.58
query22	2.44	2.06	2.37
query23	17.33	0.95	0.84
query24	3.12	0.51	0.53
query25	0.13	0.15	0.13
query26	0.42	0.14	0.13
query27	0.04	0.04	0.04
query28	11.44	1.09	1.06
query29	12.56	3.26	3.25
query30	0.24	0.05	0.05
query31	2.88	0.38	0.38
query32	3.27	0.46	0.46
query33	3.05	3.04	3.04
query34	17.13	4.46	4.48
query35	4.50	4.53	4.52
query36	0.68	0.48	0.47
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.11
query41	0.07	0.02	0.02
query42	0.03	0.02	0.01
query43	0.04	0.03	0.03
Total cold run time: 108.18 s
Total hot run time: 32.89 s

@morrySnow morrySnow added usercase Important user case type label dev/2.0.x dev/2.1.x dev/3.0.x labels Sep 24, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 47ce9f9 into apache:master Sep 24, 2024
25 of 28 checks passed
@morrySnow morrySnow deleted the fix_decimalv3_simplify branch September 24, 2024 09:35
@morrySnow morrySnow added the p0_c label Sep 25, 2024
@morrySnow morrySnow mentioned this pull request Sep 26, 2024
Merged
morrySnow added a commit that referenced this pull request Sep 26, 2024
@morrySnow
[fix](Nereids) simplify decimal comparison wrong when cast to smaller…
446c6b5 
… scale (#41151) (#41364)

pick from master #41151
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 9, 2024
@morrySnow
[fix](Nereids) simplify decimal comparison wrong when cast to smaller…
308ed7c 
… scale (apache#41151)

pick from master apache#41151
@morrySnow morrySnow mentioned this pull request Oct 9, 2024
Merged
morrySnow added a commit that referenced this pull request Oct 9, 2024
@morrySnow
[fix](Nereids) simplify decimal comparison wrong when cast to smaller…
a45dc87 
… scale (#41151) (#41618)

pick from master #41151
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 29, 2024
@morrySnow
[fix](Nereids) simplify decimal comparison wrong when cast to smaller…
7683b58 
… scale (apache#41151)

pick from master apache#41151
@morrySnow morrySnow mentioned this pull request Oct 29, 2024
Merged
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 30, 2024
@morrySnow
[fix](Nereids) simplify decimal comparison wrong when cast to smaller…
9306484 
… scale (apache#41151)

pick from master apache#41151
morrySnow added a commit that referenced this pull request Oct 31, 2024
@morrySnow
[fix](Nereids) simplify decimal comparison wrong when cast to smaller…
3877a7a 
… scale (#41151) (#42871)

pick from master #41151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.16-merged dev/2.1.7-merged dev/3.0.2-merged p0_c reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morrySnow @doris-robot @starocean999 @feiniaofeiafei @dataroaring