make asan work as much as possible #8148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the 1st patch to make asan work.
Before this patch a use after poison is reported like below ==19305==ERROR: AddressSanitizer: unknown-crash on address 0x625000137013 at pc 0x561c44bcf6b8 bp 0x7ffb75a00910 sp 0x7ffb75a000b8 After this patch the use after poison is reported like below ==17782==ERROR: AddressSanitizer: use-after-poison on address 0x625000137033 at pc 0x55633c8f56b8 bp 0x7ff3dc437930 sp 0x7ff3dc43 Before this patch, a false memory usage is reported like below ==33080==AddressSanitizer CHECK failed: ../../../../src/libsanitizer/ asan/asan_allocator.cpp:189 "((old)) == ((kAllocBegMagic))" This is the 2nd patch to make ASAN work.
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
|
Hi @dataroaring this pr will cause |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
make asan work as much as possible
Issue Number: close #xxx
Problem Summary:
Manually ASAN poisoning is complicated and it is hard to make it work right. There are illustrated examples in http://blog.hostilefork.com/poison-memory-without-asan/.
Stacks of use after poison do not provide enough information to resolve bug, while stacks of use afer free provide. google/sanitizers#191
We'd better implement a mempool using malloc/free directly, thus asan works natively. However we cannot do it in a short time, so we make manual poisoning work as much as possible.
I refers to https://github.com/mcgov/asan_alignment_example.
Checklist(Required)
Further comments
We need much more work to make asan work, for example we need fix manual poison in ./be/src/olap/rowset/segment_v2/bitshuffle_page.h and I am not sure if there are any places.