[MINOR-UPDATE]: Drop conjars repo and revert ci.yml runner image to ubuntu-latest #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jnturton
commented
Mar 30, 2023
•
jnturton
commented
- Set drill.version in drill-udf/pom.xml to 1.22.0-SNAPSHOT.
- Drop conjars repository.
- Upgrade parquet to 1.12.3 and parquet-format to 2.9.0.
- Move Splunk Maven repository declaration to contrib/storage-splunk/pom.xml.
- Revert ci.yml to ubuntu-latest.
- Add RPC and HTTP bind address lines to drill-override-example.conf.
GtiHub have updated the Ubuntu 22.04 (latest) runner image again and suggested that we test for the regression found in the 20220305 image.
jnturton
added
minor-update
backport-to-stable
|
Unsubscribe
…On Thu, 30 Mar, 2023, 14:16 James Turton, ***@***.***> wrote:
1. Adds the mentioned examples as a follow up to DRILL-8409.
2. Tests whether the GitHub Runner image regression in ubuntu-latest
has been fixed by their new image update.
------------------------------
You can view, comment on, or merge this pull request online at:
#2782
Commit Summary
- 05f457a
<05f457a>
Add RPC and HTTP bind address lines to drill-override-example.conf.
- e6afa18
<e6afa18>
Revert ci.yml to ubuntu-latest.
File Changes
(2 files <https://github.com/apache/drill/pull/2782/files>)
- *M* .github/workflows/ci.yml
<https://github.com/apache/drill/pull/2782/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f>
(2)
- *M* distribution/src/main/resources/drill-override-example.conf
<https://github.com/apache/drill/pull/2782/files#diff-28fae7ab1b849f9c54941d86f81cd5d8c34adf9addccfba505ca86222430df82>
(4)
Patch Links:
- https://github.com/apache/drill/pull/2782.patch
- https://github.com/apache/drill/pull/2782.diff
—
Reply to this email directly, view it on GitHub
<#2782>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZFXPU23WZIDLQDABJKRT3W6VB7LANCNFSM6AAAAAAWM65TTE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
It looks like the CI runs failed because conjars is unable to serve all the requests it's getting at the moment. I'm not sure whether to wait before trying again... |
|
I guess we'll just have to try kicking the CI off again tomorrow to get confirmation that the |
jnturton
changed the title
cgivre
approved these changes
Apr 3, 2023
|
@jnturton I've checked my local maven repository and found that there are only 2 dependencies that were downloaded from conjars repository: $ for file in `find ~/.m2/repository/ -name "_remote.repositories"`; do grep $file -e "conjars"; done
pentaho-aggdesigner-5.1.5-jhyde.pom>conjars=
pentaho-aggdesigner-algorithm-5.1.5-jhyde.pom>conjars=
pentaho-aggdesigner-algorithm-5.1.5-jhyde.jar>conjars=But neither is used in Drill now. So yea, we can just remove redundant conjars repo. |
|
Thanks for checking @rymarm . |
kingswanwho
pushed a commit
to kingswanwho/drill
that referenced
this pull request
Apr 4, 2023
…buntu-latest (apache#2782) * Add RPC and HTTP bind address lines to drill-override-example.conf. * Revert ci.yml to ubuntu-latest. * Move Splunk Maven repository declaration to contrib/storage-splunk/pom.xml. * Upgrade parquet to 1.12.3 and parquet-format to 2.9.0. * Drop conjars repository. * Set drill.version in drill-udf/pom.xml to 1.21.0.
jnturton
added a commit
that referenced
this pull request
Apr 18, 2023
…buntu-latest (#2782) * Add RPC and HTTP bind address lines to drill-override-example.conf. * Revert ci.yml to ubuntu-latest. * Move Splunk Maven repository declaration to contrib/storage-splunk/pom.xml. * Upgrade parquet to 1.12.3 and parquet-format to 2.9.0. * Drop conjars repository. * Set drill.version in drill-udf/pom.xml to 1.21.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.