Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerDiscoverySelector.stop() not idempotent #2123

Closed
drcrallen opened this issue Dec 18, 2015 · 2 comments
Closed

ServerDiscoverySelector.stop() not idempotent #2123

drcrallen opened this issue Dec 18, 2015 · 2 comments
Labels
Milestone

Comments

@drcrallen
Copy link
Contributor

2015-12-18T12:19:51,982 ERROR [Thread-77] com.metamx.common.lifecycle.Lifecycle$AnnotationBasedHandler - Exception when stopping method[public void io.druid.curator.discovery.ServerDiscoverySelector.stop() throws java.io.IOException] on object[io.druid.curator.discovery.ServerDiscoverySelector@26e0d39c]
java.lang.reflect.InvocationTargetException
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_66]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_66]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_66]
    at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
    at com.metamx.common.lifecycle.Lifecycle$AnnotationBasedHandler.stop(Lifecycle.java:337) [druid-selfcontained-0.8.3-rc2-mmx1.jar:0.8.3-rc2-mmx1]
    at com.metamx.common.lifecycle.Lifecycle.stop(Lifecycle.java:261) [druid-selfcontained-0.8.3-rc2-mmx1.jar:0.8.3-rc2-mmx1]
    at io.druid.cli.CliPeon$2.run(CliPeon.java:241) [druid-selfcontained-0.8.3-rc2-mmx1.jar:0.8.3-rc2-mmx1]
    at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
Caused by: java.lang.IllegalStateException: Already closed or has not been started
    at com.google.common.base.Preconditions.checkState(Preconditions.java:176) ~[druid-selfcontained-0.8.3-rc2-mmx1.jar:0.8.3-rc2-mmx1]
    at org.apache.curator.x.discovery.details.ServiceCacheImpl.close(ServiceCacheImpl.java:104) ~[druid-selfcontained-0.8.3-rc2-mmx1.jar:0.8.3-rc2-mmx1]
    at org.apache.curator.x.discovery.details.ServiceProviderImpl.close(ServiceProviderImpl.java:78) ~[druid-selfcontained-0.8.3-rc2-mmx1.jar:0.8.3-rc2-mmx1]
    at io.druid.curator.discovery.ServerDiscoverySelector.stop(ServerDiscoverySelector.java:122) ~[druid-selfcontained-0.8.3-rc2-mmx1.jar:0.8.3-rc2-mmx1]
    ... 8 more
@drcrallen drcrallen added the Bug label Dec 18, 2015
@drcrallen drcrallen added this to the 0.8.3 milestone Dec 18, 2015
@drcrallen
Copy link
Contributor Author

Should be solved by #2063 via metamx/java-util#28

@drcrallen
Copy link
Contributor Author

Note this is probably not a regression, but simply exposing prior behavior in the logs since #1387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant