-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SQL operators for bitwise expressions #10823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the website changes. What is going on there?
@@ -214,6 +217,9 @@ | |||
"title": "Amazon Kinesis ingestion", | |||
"sidebar_label": "Amazon Kinesis" | |||
}, | |||
"development/extensions-core/druid-kubernetes": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What? Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O strange, this was apparently auto-generated by running spellcheck locally, I just confirmed this by running npm run lint && npm run spellcheck
on website in master and I get the same diff on this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, but, okay. Next time please do this stuff in a separate commit so we can keep them clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍, I didn't actually realize it was there until you pointed it out, i just ran the spell check to make sure i fixed the errors in the docs and staged and pushed up all changes without really looking at them 😅
Any idea what this file is for? Something with localization i would guess, but not sure if it is important, like should it be another commit to get pulled in to 0.21.0? Though I guess its possible that since building the website-src pulls in druid and does this build, that it might pick up the changes that happen to this file anyway as a side-effect.
Description
Follow up to #10605, adds SQL operator bindings to bitwise expressions.
For example, doing nonsense with wikipedia data:
This PR has: