Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SQL operators for bitwise expressions #10823

Merged
merged 5 commits into from
Feb 19, 2021

Conversation

clintropolis
Copy link
Member

Description

Follow up to #10605, adds SQL operator bindings to bitwise expressions.

For example, doing nonsense with wikipedia data:
Screen Shot 2021-01-31 at 9 32 56 PM


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the website changes. What is going on there?

@@ -214,6 +217,9 @@
"title": "Amazon Kinesis ingestion",
"sidebar_label": "Amazon Kinesis"
},
"development/extensions-core/druid-kubernetes": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? Why?

Copy link
Member Author

@clintropolis clintropolis Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O strange, this was apparently auto-generated by running spellcheck locally, I just confirmed this by running npm run lint && npm run spellcheck on website in master and I get the same diff on this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, but, okay. Next time please do this stuff in a separate commit so we can keep them clean.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, I didn't actually realize it was there until you pointed it out, i just ran the spell check to make sure i fixed the errors in the docs and staged and pushed up all changes without really looking at them 😅

Any idea what this file is for? Something with localization i would guess, but not sure if it is important, like should it be another commit to get pulled in to 0.21.0? Though I guess its possible that since building the website-src pulls in druid and does this build, that it might pick up the changes that happen to this file anyway as a side-effect.

@clintropolis clintropolis merged commit cbbef80 into apache:master Feb 19, 2021
@clintropolis clintropolis deleted the bitwise-sql branch February 19, 2021 04:56
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants