-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First refactor of compaction docs #10935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this up! I think it's a much-needed improvement. Added some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments & suggestions below.. Looks good though! It makes compaction clearer.
I echo others comments on this PR. This is a huge improvement - thank you @techdocsmith ! I haven't verified the correctness of how exactly compaction works, or the details of the different tuning knobs Some overall structural feedback (doesn't need to be addressed in this PR):
|
Docs failure looks legit
|
Apologize for that @suneet-s , I fixed links and spelling in a later commit. |
…anularity. removes duplicated doc
2a3bbb5
to
bee7f74
Compare
add granularityspec to example
#10897
First pass refactor / update of compaction docs
Updates to "Data management" topic as follows:
Adds a new topic "Compaction" that defines compaction and automatic compaction as a strategy for segment optimization.
Repairs links for the refactor above.
This PR doesn't handle the remaining task of identifying reindexing and compaction as data management tasks for existing data and comparing the use cases between the two. This should come in a subsequent PR.
cc: @maytasm, @suneet-s , @loquisgon , @sthetland
This PR has: