StringComparators: No need to convert to UTF-8 for lexicographic comparison. #11171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arison. Lexicographic ordering of UTF-8 byte sequences and in-memory UTF-16 strings are equivalent. So, we can skip the (expensive) conversion and get an equivalent result. Thank you, Unicode!
clintropolis
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Heh, this has been like this since topN was added 😄 50a6839#diff-10d947f7e5fa97a2ece2629950472d210574627f9f728f2e934b8a8b001fa4bbR46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lexicographic ordering of UTF-8 byte sequences and in-memory UTF-16
strings are equivalent. So, we can skip the (expensive) conversion and
get an equivalent result. Thank you, Unicode!