Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dimension partitioningType to metrics to track usage of different partitioning schemes #11902

Merged
merged 5 commits into from
Nov 11, 2021

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Nov 10, 2021

Changes

  • Add method ShardSpec.getType() to get name of shard spec type
  • List all names of shard spec types in the interface ShardSpec itself
    for easy reference and maintenance
  • Add dimension partitioningType to metric segment/added/bytes

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Contributor

@abhishekagarwal87 abhishekagarwal87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhishekagarwal87 abhishekagarwal87 merged commit 223c569 into apache:master Nov 11, 2021
@abhishekagarwal87
Copy link
Contributor

merged since ci failure is unrelated

@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
@kfaraz kfaraz deleted the multi_dim_metrics branch September 30, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants