Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocompaction support for complex dimensions #11924

Merged
merged 2 commits into from
Nov 16, 2021
Merged

autocompaction support for complex dimensions #11924

merged 2 commits into from
Nov 16, 2021

Conversation

clintropolis
Copy link
Member

Description

This PR adds auto-compaction support for complex dimensions by adding

DimensionSchema getDimensionSchema(ColumnCapabilities capabilities);

to DimensionHandler, so that CompactionTask can create the correction DimensionSchema for any complex types that have been registered with DimensionHandlerUtils.registerDimensionHandlerProvider.

Key changed/added classes in this PR
  • CompactionTask

This PR has:

  • been self-reviewed.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

@gianm gianm merged commit 7f0bede into apache:master Nov 16, 2021
@clintropolis clintropolis deleted the compaction-with-custom-dimensions branch November 17, 2021 00:17
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
@abhishekagarwal87 abhishekagarwal87 mentioned this pull request May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianm gianm gianm approved these changes

Assignees
No one assigned
Labels
Area - Compaction
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clintropolis @gianm @abhishekagarwal87