Fix issues when startup timeout is hit #14425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the K8s Task Runner when k8sjobLaunchTimeout is hit during launchPeonJobAndWaitForStart in KubernetesPeonLifecycle.run without the task pod successfully coming up, e.g. when there is no available node.
Currently if a task pod fails to come up in time, the overlord marks the task as failed and logs the timeout error message, but doesn't actually cleanup the job. Eventually the cleanupExecutor will cleanup the job, but it's possible for the job to fail to come up in k8sjobLaunchTimeout, then succeed afterwards and actually run even though the overlord has marked it as failed.
Release note
Fix a bug with the K8s overlord extension
Key changed/added classes in this PR
Update KubernetesPeonsLifecycle to cleanup jobs it has tried to start and that haven't come up.
This PR has: