Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues when startup timeout is hit #14425

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

georgew5656
Copy link
Contributor

Description

Fixes a bug in the K8s Task Runner when k8sjobLaunchTimeout is hit during launchPeonJobAndWaitForStart in KubernetesPeonLifecycle.run without the task pod successfully coming up, e.g. when there is no available node.

Currently if a task pod fails to come up in time, the overlord marks the task as failed and logs the timeout error message, but doesn't actually cleanup the job. Eventually the cleanupExecutor will cleanup the job, but it's possible for the job to fail to come up in k8sjobLaunchTimeout, then succeed afterwards and actually run even though the overlord has marked it as failed.

Release note

Fix a bug with the K8s overlord extension

Key changed/added classes in this PR

Update KubernetesPeonsLifecycle to cleanup jobs it has tried to start and that haven't come up.

This PR has:

  • [ X] been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [X ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • [X ] been tested in a test Druid cluster.

Copy link
Contributor

@suneet-s suneet-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@suneet-s suneet-s merged commit 76e7065 into apache:master Jun 14, 2023
@abhishekagarwal87 abhishekagarwal87 added this to the 27.0 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants