Completely disable cachingCost balancer strategy #14798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,7 @@ | |||
| @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "strategy", defaultImpl = CostBalancerStrategyFactory.class) | |||
| @JsonSubTypes(value = { | |||
| @JsonSubTypes.Type(name = "cost", value = CostBalancerStrategyFactory.class), | |||
| @JsonSubTypes.Type(name = "cachingCost", value = CachingCostBalancerStrategyFactory.class), | |||
There was a problem hiding this comment.
CachingCostBalancerStrategyFactory should be removed from code.
There was a problem hiding this comment.
It is being used in some coordinator simulations and I have kept it around for the time being for some benchmarking and correctness comparison with upcoming strategies. It will most likely be removed before the next release of Apache Druid.
There was a problem hiding this comment.
Added javadoc to this effect.
abhishekagarwal87
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cachingCosthas been deprecated in #14484 and is not advised to be used in production clusters as it may cause usage skew across historicals which the coordinator is unable to rectify. This PR completely disablescachingCoststrategy as it has now been rendered redundant due to recent performance improvements made tocoststrategy.Changes
cachingCoststrategyDisabledCachingCostBalancerStrategyFactoryfor the time being so that we can give a proper error message before falling back toCostBalancerStrategy. This will be removed in subsequent releases.CachingCostBalancerStrategyand related classes for testing and benchmarking purposes.DiskCostBalancerStrategy.Release note
cachingCostbalancer strategy is now disabled and cannot be used in a Druid cluster. UsingcachingCostfalls back tocostbalancer strategy.