Tackle "merged" dir. issue after restarting realtime node #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue if you restart realtime node and merged dir is still there it will throw exceptions. To tackle this issue a check has been added. So now only persisted dir/files will be read and anything from "merged" will be avoided.
| final File[] sinkFiles = sinkDir.listFiles(new FilenameFilter() { | ||
| @Override | ||
| public boolean accept(File dir, String fileName) { | ||
| return !fileName.equalsIgnoreCase("merged"); |
There was a problem hiding this comment.
Rather than just checking for "merged" the problem is actually that it cannot parse an int out of the word "merged". I'd be more comfortable if this were actually a parsing check:
return Ints.tryParse(fileName) != null;There was a problem hiding this comment.
Ok .. that sounds fine and I hope we won't be changing logic of putting numeric names.
Put a check to make sure that we're only looking for the folder those have number-only names, to avoid "merged" directory issue.
cheddar
added a commit
that referenced
this pull request
Jun 14, 2013
Tackle "merged" dir. issue after restarting realtime node
himanshug
pushed a commit
to himanshug/druid
that referenced
this pull request
Jan 20, 2016
cherry pick druid.io changes to be able to base ci_tests on community code
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue if you restart realtime node and merged dir is still there it will throw exceptions. To tackle this issue a check has been added. So now only persisted dir/files will be read and anything from "merged" will be avoided.