Web console: more robust durable storage setting detection #16493
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akshat-Jain
reviewed
May 22, 2024
| @@ -89,6 +89,10 @@ export function addOrUpdate<T>(xs: readonly T[], x: T, keyFn: (x: T) => string | | |||
|
|
|||
| // ---------------------------- | |||
|
|
|||
| export function caseInsensitiveEquals(str1: string | undefined, str2: string | undefined): boolean { | |||
| return str1?.toLowerCase() === str2?.toLowerCase(); | |||
There was a problem hiding this comment.
This would throw a NPE if str1 or str2 are null, right? If yes, I think we should handle that as well since this is a utility function.
There was a problem hiding this comment.
no that is what the ? before the . is for. It is essentially doing (str1 ? str1.toLowerCase() : undefined) === (str2 ? str2.toLowerCase() : undefined). Added a test case so you can verify
There was a problem hiding this comment.
Ah I see, thanks for the clarification!
Akshat-Jain
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the docs tell people to set
"selectDestination": "DURABLESTORAGE"(which works) but the console check fordurableStorage. Fix the docs and make the console check more robust.