Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default `WHERE' filter for automatically generated SQL queries is returned #16608

Merged
merged 2 commits into from
Jun 24, 2024
Merged

The default `WHERE' filter for automatically generated SQL queries is returned #16608

merged 2 commits into from
Jun 24, 2024

Conversation

nozjkoitop
Copy link
Contributor

Returned the default WHERE filter to auto-generated SQL queries, which was lost after web-console updates in druid version 24.0.0 (#12919, #13169)

image

image

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@nozjkoitop nozjkoitop changed the title Returned the default WHERE filter for auto-generated SQL queries The default `WHERE' filter for automatically generated SQL queries is returned Jun 14, 2024
cryptoe
cryptoe approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@cryptoe cryptoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me.
@vogievetsky WDYT ?

@cryptoe
Copy link
Contributor

cryptoe commented Jun 17, 2024

@nozjkoitop Could you please fix the linting issues.

@nozjkoitop
Copy link
Contributor Author

@nozjkoitop Could you please fix the linting issues.

Fixed

vogievetsky
vogievetsky approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing.

@vogievetsky vogievetsky merged commit 354a3be into apache:master Jun 24, 2024
12 checks passed
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogievetsky vogievetsky vogievetsky approved these changes

@cryptoe cryptoe cryptoe approved these changes

Assignees

@vogievetsky vogievetsky

Labels
Area - Web Console
Projects
None yet
Milestone
31.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nozjkoitop @cryptoe @vogievetsky @kfaraz