Poll rules immediately after change #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -377,7 +376,7 @@ public Void inTransaction(Handle handle, TransactionStatus transactionStatus) th | |||
| return false; | |||
| } | |||
| } | |||
|
|
|||
| poll(); | |||
There was a problem hiding this comment.
May throw exception if DB connection is disrupted. The repeating runnable in start() handles such a case.
There was a problem hiding this comment.
OK, handling exception the same way as Runnable in start()
|
👍 I'm happy this finally got fixed :D |
xvrl
added a commit
that referenced
this pull request
Aug 25, 2015
Poll rules immediately after change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users get confused when they don't see the updated rules they just submitted on coordinator console and try to apply it multiple times.