Correct aggregators violating names #16615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that change is the finalization stuff in action; how the finalization happens after these changes? I'm not sure if forcing the column name would be the best - as for some reason the original aggfactory have decided to add a postagg - we can't really ignore that....if the base aggregate factory is not prepared to do the finalization implicitly then I guess that might go south...so I think we should probably look for some alternate path:
|
sreemanamala
changed the title
|
@kgyrtkirk can you please review the comments ? |
kgyrtkirk
reviewed
Jul 11, 2024
| .queryContext(ImmutableMap.of( | ||
| PlannerContext.CTX_ENABLE_WINDOW_FNS, true, | ||
| QueryContexts.ENABLE_DEBUG, true, | ||
| QueryContexts.WINDOWING_STRICT_VALIDATION, false |
There was a problem hiding this comment.
this will break the other PR; so after one of these gets merged - to other needs updates
kgyrtkirk
approved these changes
Jul 11, 2024
sreemanamala
added a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
In case of few aggregators for example BloomSqlAggregator, BaseVarianceSqlAggregator etc, the aggName is being updated from a0 to a0:agg, breaching the contract as we would expect the aggName as the name which is passed. This is causing a mismatch while creating a column accessor. This commit aims to correct those violating sql aggregators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case of few aggregators for example BloomSqlAggregator, BaseVarianceSqlAggregator etc, the aggName is being updated from
a0 to a0:agg, breaching the contract as we would expect the aggName as the name which is passed. This is causing a mismatch while creating a column accessor.This commit aims to correct those violating sql aggregators.
Key changed/added classes in this PR
CompressedBigDecimalSqlAggregatorBaseTDigestGenerateSketchSqlAggregatorDoublesSketchObjectSqlAggregatorBloomFilterSqlAggregatorBaseVarianceSqlAggregatorThis PR has: