Add hashCode and equals to UniformGranularitySpec #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,7 +62,7 @@ public boolean equals(Object o) | |||
| @Override | |||
| public int hashCode() | |||
| { | |||
| return 0; | |||
| return getClass().hashCode(); | |||
There was a problem hiding this comment.
can you explain why this is necessary?
There was a problem hiding this comment.
otherwise All and None have a hash collision. Minor detail, and I can take it out if people are worried about the impact.
There was a problem hiding this comment.
ok, then we can just make it 0 for none and 1 for all, if collisions are a problem. Seems unnecessary to use class name.
There was a problem hiding this comment.
changed to -1, and 1 as per conversation on slack
* Also add hashCode != 0 to AllGranularity and NoneGranularity
drcrallen
force-pushed
the
UniformGranularitySpecHashEquals
branch
from
ce9ca54
to
f432b8e
Compare
|
LGTM |
|
👍 |
fjy
added a commit
that referenced
this pull request
Oct 26, 2015
Add hashCode and equals to UniformGranularitySpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing some problems in unit tests in some libraries I'm developing.