Do not pass druid.indexer.runner.javaOpts to Peon as a property
#1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,7 +187,8 @@ public TaskStatus call() | |||
|
|
|||
| for (String propName : props.stringPropertyNames()) { | |||
| for (String allowedPrefix : config.getAllowedPrefixes()) { | |||
| if (propName.startsWith(allowedPrefix)) { | |||
| // See https://github.com/druid-io/druid/issues/1841 | |||
| if (propName.startsWith(allowedPrefix) && !"druid.indexer.runner.javaOpts".equals(propName)) { | |||
There was a problem hiding this comment.
extract this as a String constant, since its used at multiple places ?
* Still places `druid.indexer.runner.javaOpts` on the command line, but the Peon no longer tries to have the property `druid.indexer.runner.javaOpts` set * Fixes apache#1841
|
👍 |
|
travis failed - |
| @@ -187,7 +187,9 @@ public TaskStatus call() | |||
|
|
|||
| for (String propName : props.stringPropertyNames()) { | |||
| for (String allowedPrefix : config.getAllowedPrefixes()) { | |||
| if (propName.startsWith(allowedPrefix)) { | |||
| // See https://github.com/druid-io/druid/issues/1841 | |||
| if (propName.startsWith(allowedPrefix) | |||
There was a problem hiding this comment.
is it possible to add UT to catch the bug mentioned?
There was a problem hiding this comment.
ForkingTaskRunner is pretty much void of unit tests. I'm trying to add some in the Tiering extension, but unless really required I'm not interested in spending the time doing UTs for something I'm trying to replace.
himanshug
added a commit
that referenced
this pull request
Oct 21, 2015
Do not pass `druid.indexer.runner.javaOpts` to Peon as a property
xvrl
added a commit
that referenced
this pull request
Dec 3, 2015
[BACKPORT #1842] Do not pass `druid.indexer.runner.javaOpts` to Peon as a property
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
druid.indexer.runner.javaOptson the command line, but the Peon no longer tries to have the propertydruid.indexer.runner.javaOptsset