-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forward cancellation request to all brokers, fixes #1802 #1888
Conversation
+1 |
try { | ||
return Collections2.transform(serviceProvider.getAllInstances(), TO_SERVER); | ||
} | ||
catch (Exception e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blanket exception catching should handle InterruptedException properly
462bd41
to
c63774c
Compare
@drcrallen addressed all the comments, URI building turned out not to be so simple when dealing with encoded parameters. |
added some tests. |
c63774c
to
5ccf7c6
Compare
); | ||
} | ||
catch (UnsupportedEncodingException | URISyntaxException e) { | ||
log.error(e, "Unable to rewrite URI", e.getMessage()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does log.error simply print out any extraneous arguments?
5ccf7c6
to
149333d
Compare
forward cancellation request to all brokers, fixes #1802
No description provided.