Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward cancellation request to all brokers, fixes #1802 #1888

Merged
merged 1 commit into from
Oct 30, 2015

Conversation

xvrl
Copy link
Member

@xvrl xvrl commented Oct 29, 2015

No description provided.

@nishantmonu51
Copy link
Member

+1

try {
return Collections2.transform(serviceProvider.getAllInstances(), TO_SERVER);
}
catch (Exception e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blanket exception catching should handle InterruptedException properly

@xvrl xvrl force-pushed the router-cancellation-forward branch from 462bd41 to c63774c Compare October 29, 2015 22:36
@xvrl
Copy link
Member Author

xvrl commented Oct 29, 2015

@drcrallen addressed all the comments, URI building turned out not to be so simple when dealing with encoded parameters.

@xvrl
Copy link
Member Author

xvrl commented Oct 29, 2015

added some tests.

@xvrl xvrl force-pushed the router-cancellation-forward branch from c63774c to 5ccf7c6 Compare October 29, 2015 22:50
);
}
catch (UnsupportedEncodingException | URISyntaxException e) {
log.error(e, "Unable to rewrite URI", e.getMessage());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does log.error simply print out any extraneous arguments?

@xvrl xvrl force-pushed the router-cancellation-forward branch from 5ccf7c6 to 149333d Compare October 29, 2015 23:58
drcrallen added a commit that referenced this pull request Oct 30, 2015
forward cancellation request to all brokers, fixes #1802
@drcrallen drcrallen merged commit 7d52a2a into apache:master Oct 30, 2015
@drcrallen drcrallen deleted the router-cancellation-forward branch October 30, 2015 22:00
@gianm gianm added this to the 0.9.0 milestone Nov 7, 2015
@gianm gianm modified the milestones: 0.8.3, 0.9.0 Dec 1, 2015
This was referenced Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants