datasketches module updates #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds support for "cardinality" aggregator. do not create sketch per event at ingestion time to make realtime ingestion faster
|
Are the data sketches backwards compatible? Meaning anything made with 1.x will be readable by 2.x? |
|
@drcrallen yes, they are. there is backward compatibility baked in with old api that we use too, as soon as this is released , we will stop using the old module that we have internally.. migrate users to new apis and eventually remove support for those. |
|
LGTM, 👍 |
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR
thetaSketchaggregator on non theta-sketch columns (similar tohyperUniqueCardinality)@cheddar can you please review this one? thanks.