Add dimension selector support for groupby/having filters #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,113 @@ | |||
| package io.druid.query.groupby.having; | |||
There was a problem hiding this comment.
can we use this new header? See: #2050
|
can you also add a test to GroupByQueryRunnerTest, just to make sure the entire groupBy query works as expected ? |
|
Adding a testcase to GroupByQueryRunnerTest is nice to have but I feel not needed for this change. |
|
|
||
| public byte[] getCacheKey() | ||
| { | ||
| byte[] dimBytes = this.dimension.getBytes(Charsets.UTF_8); |
|
After reading #1984 I am 👍 on this. Please squash commits. |
mangesh-pardeshi
force-pushed
the
master
branch
from
2803566
to
d7ce120
Compare
|
👍 |
nishantmonu51
added a commit
that referenced
this pull request
Dec 8, 2015
Add dimension selector support for groupby/having filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.