Fix loadRule when one of the tiers had no available servers #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When one of the tiers have no servers, LoadRule should ignore that tier and continue to load/drop segments in other available tiers. the bug also causes whacky behavior with LoadRule with non existent tier where the segment balancer keeps on moving segments to other nodes in existing tiers but the extra segment copies are never dropped eventually leading to all the tiers getting full .
| private static final ServiceEmitter emitter = new ServiceEmitter( | ||
| "service", | ||
| "host", | ||
| new LoggingEmitter( |
There was a problem hiding this comment.
Do you need to have a logging emitter here? It seems to me it would make more sense to have either something you can capture events, or something that's a NoOp
|
Minor questions from my side, ok as is if they are rejected by author 👍 |
|
👍 |
drcrallen
added a commit
that referenced
this pull request
Jan 11, 2016
Fix loadRule when one of the tiers had no available servers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one of the tiers have no servers, LoadRule should ignore that tier
and continue to load/drop segments in other available tiers.
the bug causes wierd behavior with LoadRule when some tier has no servers where the segment balancer keeps on moving segments to other nodes in existing tiers but the extra segment copies are never dropped eventually leading to all the tiers getting full .