Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AggregatorFactory to interface #2504

Closed
wants to merge 1 commit into from

Conversation

navis
Copy link
Contributor

@navis navis commented Feb 19, 2016

I've read conversations in #1728 and also prefer interface than abstract class. This is a simple try to change it to interface. I'm welcome any kind of opinions.

@navis navis added the Discuss label Feb 19, 2016
@navis navis force-pushed the aggregator-factory-interface branch from d946fce to b19f53f Compare February 19, 2016 02:31
@gianm
Copy link
Contributor

gianm commented Feb 19, 2016

I like it as an interface (they just seem cleaner to me when reviewing classes written by others- no need to verify that the base impl actually makes sense in the subclass). But if we are gonna do that, we better do it fast as it would be backwards incompatible and would need to either make it into 0.9.0 or wait for 0.10.0.

Fwiw I am also okay with leaving it the way it is, if people think it is too much of a hassle to change or just plain not worth it.

maybe we can discuss at the dev sync next tuesday.

@fjy
Copy link
Contributor

fjy commented Aug 29, 2016

@himanshug feedback here is appreciated as I think you made the change to make Agg factories into abstract classes.

I also prefer interfaces.

@stale
Copy link

stale bot commented Feb 28, 2019

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Feb 28, 2019
@stale
Copy link

stale bot commented Mar 7, 2019

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale bot closed this Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants