DataSegmentPusher: Add allowed hadoop property prefixes. #4562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@gianm thanks ! |
gianm
added a commit
to gianm/druid
that referenced
this pull request
Jul 18, 2017
* DataSegmentPusher: Add allowed hadoop property prefixes. * Fix dots.
jon-wei
pushed a commit
that referenced
this pull request
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4536 by adding a method to DataSegmentPusher.
Also changes the built-in allowed property prefixes so they are always added. I think that makes more sense, otherwise a user-provided list might break something built-in (like a Pusher's list). Also changes the prefixes from looking like "druid.xxx." to looking like "druid.xxx". This is useful for stuff like "druid.emitter", where "druid.emitter" is a property but so is "druid.emitter.foo".
I think these behavior changes are all fine for a minor release since allowedHadoopPrefix wasn't documented yet.