Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for PostgreSQL Metadata Store SSL Configuration Settings is incorrect #6884

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

navkumar
Copy link
Contributor

Originally filed in druid-io.github.io

On this page in the documentation for the PostgreSQL Metadata Store (http://druid.io/docs/latest/development/extensions-core/postgresql.html), the settings table at the bottom uses incorrect properties that do not work in the latest (0.13.0-incubating) version of Druid.

According to the code here (PostgreSQLMetadataStorageModule.java), the SSL related settings are all prefixed with druid.metadata.postgres.ssl NOT druid.metadata.postgres as indicated on this documentation page. For example, you would enable SSL for PostgreSQL using the something like the following in runtime.properties:

...
# ALL THESE PROPERTIES ARE PREFIXED with "druid.metadata.postgres.ssl"
druid.metadata.postgres.ssl.enableSSL=true
druid.metadata.postgres.ssl.sslMode=verify-full
druid.metadata.postgres.ssl.sslRootCert=<path-to-ca.crt>
...

instead of:

...
# NONE OF THESE ARE READ BY THE POSTGRES METADATA STORAGE EXTENSION
druid.metadata.postgres.enableSSL=true
druid.metadata.postgres.sslMode=verify-full
druid.metadata.postgres.sslRootCert=<path-to-ca.crt>
...

I have updated the options to reflect the updated logic in the code.

Change `druid.metadata.postgres.*` to `druid.metadata.postgres.ssl.*`
Copy link
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge even without CI passing; it must be a false positive since this is just a doc change.

@gianm gianm merged commit ae4dba7 into apache:master Jan 27, 2019
@jon-wei jon-wei added this to the 0.14.0 milestone Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants