consolidate CompressionUtils files in druid-core, move 'makeEvilZip' to tests #6908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6443, moves
CompressionUtils.java
of the formerjava-util
to the place ofCompressionUtils.java
of the formerdruid-api
(since it is marked@PublicApi
).The latter was a wrapper around the former, with the exception of this method:
which mentioned in it's javadoc:
I don't think it's likely a big deal, as far as I can tell this method has been marked deprecated since before
druid-api
was moved into the main repo (over 3 years ago), but we should probably call out in release notes.Additionally,
makeEvilZip
, which sounds way too scary to be in the core library and was only used by tests has been moved out ofCompressionUtils
and intoCompressionUtilsTest
.druid-hadoop-indexing
was also using this method, so it now includes a test reference todruid-core
for test jar.Unfortunately this is showing up in github as deleting the
java-util
version instead of moving it to the previously same named files location, but the only change to thejava-util
version is the addition of@PublicApi
and moving themakeEvilZip
to the test.I would like to move the other assortment of
*Utils.java
classes scattered arounddruid-core
toorg.apache.druid.utils
package as well, but thought it conservative to split this out first since it's not totally cosmetic.