Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lookups view to allow adding/editing/deleting of druid lookups #7259

Merged
merged 3 commits into from
Mar 16, 2019
Merged

Add lookups view to allow adding/editing/deleting of druid lookups #7259

merged 3 commits into from
Mar 16, 2019

Conversation

shuqi7
Copy link
Contributor

@shuqi7 shuqi7 commented Mar 13, 2019

Refers to Druid lookups: http://druid.io/docs/latest/querying/lookups.html

  • Lookups page to allow users to view existing lookups, add new lookups, and edit lookups
    image
  • Allow users to use ISO string as current version, and will pre-fill current ISO as version when users add new lookups
    image
  • Spec refers to the JSON object in lookupExtractorFactory
  • If the user has NEVER configured lookups before, he must initialize the configuration first
    image

@shuqi7 shuqi7 changed the title Add lookups view to allow adding/editing/deleting of druid lookups [Console] Add lookups view to allow adding/editing/deleting of druid lookups Mar 13, 2019
@fjy fjy added this to the 0.15.0 milestone Mar 13, 2019
@vogievetsky
Copy link
Contributor

I have reviewed these changes already and it has my 👍
Some of my review comments (that have already been addresses) can be found here: https://github.com/implydata/druid/pull/19

@gianm gianm changed the title [Console] Add lookups view to allow adding/editing/deleting of druid lookups Add lookups view to allow adding/editing/deleting of druid lookups Mar 15, 2019
@clintropolis
Copy link
Member

Is there a reason why the dialog lookup editor doesn't take up more screen width? Might make it a bit nicer to work with.

Screen Shot 2019-03-15 at 4 54 33 PM

@shuqi7
Copy link
Contributor Author

shuqi7 commented Mar 16, 2019

Is there a reason why the dialog lookup editor doesn't take up more screen width? Might make it a bit nicer to work with.

Screen Shot 2019-03-15 at 4 54 33 PM

Made it wider by setting it to 600px, which I think is more user-friendly while still looking pretty

@clintropolis clintropolis merged commit 1b6b40e into apache:master Mar 16, 2019
@shuqi7 shuqi7 deleted the lookups-view branch March 18, 2019 17:05
clintropolis pushed a commit to implydata/druid-public that referenced this pull request Apr 3, 2019
@shuqi7 @clintropolis
Add lookups view to allow adding/editing/deleting of druid lookups (a…
28a2c00 
…pache#7259)

* Add lookups view to allow adding/editing/deleting of druid lookups

* Remove unused bp3 class

* Make lookup editor dialog wider
gianm pushed a commit to implydata/druid-public that referenced this pull request Apr 8, 2019
@shuqi7 @gianm
Add lookups view to allow adding/editing/deleting of druid lookups (a…
30a5194 
…pache#7259)

* Add lookups view to allow adding/editing/deleting of druid lookups

* Remove unused bp3 class

* Make lookup editor dialog wider
@jihoonson jihoonson mentioned this pull request May 13, 2019
Merged
@jihoonson jihoonson mentioned this pull request Jun 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintropolis clintropolis clintropolis approved these changes

Assignees

@clintropolis clintropolis

Labels
Area - Web Console
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shuqi7 @vogievetsky @clintropolis @fjy