support radians and degrees in sql #7336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xueyumusic
force-pushed
the
sql_radiansdegrees
branch
from
4be3027
to
aa9d22b
Compare
|
@xueyumusic could you please check the test failure. |
|
@surekhasaharan , thanks for reminding. It looks the the order of virtualColumns of this test case might be a little randoms..I will look it deeper.. |
|
Updated, @surekhasaharan , thanks~ |
|
thanks @xueyumusic for quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current query math functions support toRadians and toDegrees, it could simply be exposed in sql.
The sql functions are "RADIANS" and "DEGREES", and the tests are added