Support var_pop, var_samp, stddev_pop and stddev_samp etc in sql #7801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure with sql compatible null handling looks maybe legitimate: https://travis-ci.org/apache/incubator-druid/jobs/539273414#L5703 You should be able to run tests locally in this mode with |
|
Hi, @clintropolis , thanks for suggestion. I updated the codes and rebased on master. |
clintropolis
reviewed
Jun 1, 2019
docs/content/querying/sql.md
Outdated
| @@ -132,6 +132,13 @@ Only the COUNT aggregation can accept DISTINCT. | |||
| |`APPROX_QUANTILE_DS(expr, probability, [k])`|Computes approximate quantiles on numeric or [Quantiles sketch](../development/extensions-core/datasketches-quantiles.html) exprs. The "probability" should be between 0 and 1 (exclusive). The `k` parameter is described in the Quantiles sketch documentation. The [DataSketches extension](../development/extensions-core/datasketches-extension.html) must be loaded to use this function.| | |||
| |`APPROX_QUANTILE_FIXED_BUCKETS(expr, probability, numBuckets, lowerLimit, upperLimit, [outlierHandlingMode])`|Computes approximate quantiles on numeric or [fixed buckets histogram](../development/extensions-core/approximate-histograms.html#fixed-buckets-histogram) exprs. The "probability" should be between 0 and 1 (exclusive). The `numBuckets`, `lowerLimit`, `upperLimit`, and `outlierHandlingMode` parameters are described in the fixed buckets histogram documentation. The [approximate histogram extension](../development/extensions-core/approximate-histograms.html) must be loaded to use this function.| | |||
| |`BLOOM_FILTER(expr, numEntries)`|Computes a bloom filter from values produced by `expr`, with `numEntries` maximum number of distinct values before false positve rate increases. See [bloom filter extension](../development/extensions-core/bloom-filter.html) documentation for additional details.| | |||
| |`VAR_POP(expr)`|Computes variance population of `expr`.| | |||
There was a problem hiding this comment.
For these functions, could you please indicate in the doc that the druid-stats extension needs to be loaded and link to it [stats extension](../development/extensions-core/stats.html)
There was a problem hiding this comment.
Thanks for review, @clintropolis . updated the doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current extension-core has
statsmodule which could computes variance population(sample) and standard deviation population(sample). We could expose them in sql based on calcite's var_pop,var_samp,stddev_pop,stddev_samp etc operators.The main modifications are:
BaseVarianceSqlAggregatorVarianceSqlAggregatorTest