Fixed a bug in HttpPostEmitter leading to ClassCastException #8205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventov
requested changes
Jul 31, 2019
There was a problem hiding this comment.
@ArtyomyuS could you please apply the same changes in comments as I did in https://github.com/apache/incubator-druid/pull/8207/files?
leventov
changed the title
leventov
changed the title
|
@leventov I updated. Thanks. |
leventov
reviewed
Aug 1, 2019
| @Test | ||
| @SuppressWarnings("unchecked") | ||
| public void testRecoveryEmitAndReturnBatch() | ||
| throws InterruptedException, IOException, NoSuchFieldException, IllegalAccessException |
There was a problem hiding this comment.
Side note: in Druid, we usually just add throws Exception if there is more than one. I don't think there may be any harm in doing that.
leventov
approved these changes
Aug 1, 2019
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Aug 1, 2019
…8205) * Issue 8206: Fixed class cast exception in case of batch recovery * Issue 8206: Added HttpPostEmitterTest license header * Issue 8206: Updated comments accordingly to code review. * Issue 8206: Updated HttpPostEmitterTest accordingly to new modifications.
clintropolis
pushed a commit
that referenced
this pull request
Aug 1, 2019
…8220) * Issue 8205: Fixed class cast exception in case of batch recovery * Issue 8205: Added HttpPostEmitterTest license header * Issue 8205: Updated comments accordingly to code review. * Issue 8205: Updated HttpPostEmitterTest accordingly to new modifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8204
Description
Fix
HttpPostEmitterclass cast exception while trying to recover a batch. The fix is straightforward just changedIntegercheck for a batch number to recover intoLong.This PR has:
For reviewers: the key changed/added classes in this PR are
HttpPostEmitterandHttpPostEmitterTest.(Add this section in big PRs to ease navigation in them for reviewers.)