-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
string column handling for long/float min/max/sum aggregators #8319
Conversation
@himanshug I will take a look probably sometime this week. In the meantime, would you check the CI failure? It looks legit.
|
@jihoonson thanks, I will fix the build tomorrow. |
…mnCapabilities(String) as is required by contract of ColumnSelectorFactory interface
@jihoonson fyi: build is actually fixed , coveralls failure is unrelated. |
Oh sorry. Forgot about this PR. Will take a look this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
@clintropolis thanks for the review @jihoonson you can skip this one as the changes here are simple and don't need multiple reviews. there will be more PRs soon, so save yourself some time :) |
@himanshug cool, I will try to review your follow-up prs! |
Fixes #8148
Same as #8243 but for long/float min/max/sum aggregators
Description
This patch adds handling of single/multi value column handling by long/float sum/min/max aggregators to do a best effort parsing string as long/float.
StringColumn[Long/Float]AggregatorWrapper
andStringColumn[Long/Float]BufferAggregatorWrapper
classes are introduced that can wrap existing long/float aggregators to handle string columns. Both of the classes are used bySimple[Long/Float]AggregatorFactory
to be used when input column is known to be of String type.This PR has: