Ability to Delete task logs and segments from Google Storage #9519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement ability to delete all tasks logs or all task logs written before a particular date when written to Google storage * implement ability to delete all segments from Google deep storage
clintropolis
approved these changes
Mar 18, 2020
| public GoogleDataSegmentKiller( | ||
| final GoogleStorage storage, | ||
| GoogleAccountConfig accountConfig, | ||
| GoogleInputDataConfig inputDataConfig) |
There was a problem hiding this comment.
formatting
Suggested change
| GoogleInputDataConfig inputDataConfig) | |
| GoogleInputDataConfig inputDataConfig | |
| ) |
Comment on lines
106
to
107
| LOG.info("Deleting all segment files from gs location [bucket: '%s' prefix: '%s']", | ||
| accountConfig.getBucket(), accountConfig.getPrefix() |
There was a problem hiding this comment.
Suggested change
| LOG.info("Deleting all segment files from gs location [bucket: '%s' prefix: '%s']", | |
| accountConfig.getBucket(), accountConfig.getPrefix() | |
| LOG.info( | |
| "Deleting all segment files from gs location [bucket: '%s' prefix: '%s']", | |
| accountConfig.getBucket(), | |
| accountConfig.getPrefix() |
| GoogleTaskLogsConfig config, | ||
| GoogleStorage storage, | ||
| GoogleInputDataConfig inputDataConfig, | ||
| CurrentTimeMillisSupplier timeSupplier) |
There was a problem hiding this comment.
Suggested change
| CurrentTimeMillisSupplier timeSupplier) | |
| CurrentTimeMillisSupplier timeSupplier | |
| ) |
Comment on lines
174
to
176
| LOG.info("Deleting all task logs from gs location [bucket: '%s' prefix: '%s'].", | ||
| config.getBucket(), config.getPrefix() | ||
| ); |
There was a problem hiding this comment.
Suggested change
| LOG.info("Deleting all task logs from gs location [bucket: '%s' prefix: '%s'].", | |
| config.getBucket(), config.getPrefix() | |
| ); | |
| LOG.info( | |
| "Deleting all task logs from gs location [bucket: '%s' prefix: '%s'].", | |
| config.getBucket(), | |
| config.getPrefix() | |
| ); |
Comment on lines
185
to
187
| LOG.info("Deleting all task logs from gs location [bucket: '%s' prefix: '%s'] older than %s.", | ||
| config.getBucket(), config.getPrefix(), new Date(timestamp) | ||
| ); |
There was a problem hiding this comment.
Suggested change
| LOG.info("Deleting all task logs from gs location [bucket: '%s' prefix: '%s'] older than %s.", | |
| config.getBucket(), config.getPrefix(), new Date(timestamp) | |
| ); | |
| LOG.info( | |
| "Deleting all task logs from gs location [bucket: '%s' prefix: '%s'] older than %s.", | |
| config.getBucket(), | |
| config.getPrefix(), | |
| new Date(timestamp) | |
| ); |
Comment on lines
168
to
170
| log.info("Deleting all task logs from s3 location [bucket: '%s' prefix: '%s'].", | ||
| config.getS3Bucket(), config.getS3Prefix() | ||
| ); |
There was a problem hiding this comment.
Suggested change
| log.info("Deleting all task logs from s3 location [bucket: '%s' prefix: '%s'].", | |
| config.getS3Bucket(), config.getS3Prefix() | |
| ); | |
| log.info( | |
| "Deleting all task logs from s3 location [bucket: '%s' prefix: '%s'].", | |
| config.getS3Bucket(), | |
| config.getS3Prefix() | |
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implement ability to delete all tasks logs or all task logs
written before a particular date when written to Google storage
implement ability to delete all segments from Google deep storage
This PR has: