druid-pac4j:add custom SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects #9695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TTPRequest objects
5 tasks
himanshug
changed the title
|
@jihoonson not sure if you already prep the new RC for 0.18.0 , if not , can you please approve this so that we can get it in? |
|
@himanshug sorry, I've already created RC 2 artifacts and am testing them. Thinking to start a new vote around noon today. Can this PR go into the next release? |
|
that would be ok, unless we end up doing a RC3 for some reason. |
|
Thanks. Hopefully not 😅. |
|
Good news. RC2 vote failed. Let's add this PR to RC3. |
clintropolis
approved these changes
Apr 15, 2020
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
Apr 15, 2020
…TTPRequest objects (apache#9695)
|
@jihoonson @clintropolis thanks |
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jun 12, 2020
…TTPRequest objects (apache#9695)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported in #8992 (comment)
Description
One such problem, reported in #8992 (comment) , was fixed by #9637 . However, pac4j appears to have different code paths with different mechanisms to make HTTP connection and this PR updates those.
This PR has: