-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dubboctl enhancement #1095
Merged
AlbumenJ
merged 51 commits into
apache:refactor-with-go
from
DMwangnima:refactor-with-go
May 2, 2023
Merged
dubboctl enhancement #1095
AlbumenJ
merged 51 commits into
apache:refactor-with-go
from
DMwangnima:refactor-with-go
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## refactor-with-go #1095 +/- ##
====================================================
+ Coverage 59.10% 59.51% +0.41%
====================================================
Files 47 47
Lines 3932 4108 +176
====================================================
+ Hits 2324 2445 +121
- Misses 1384 1421 +37
- Partials 224 242 +18
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlbumenJ
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Enhance dubboctl based on initial phase.
Brief changelog
Implement manifest diff and manifest uninstall.
Add some log sentences.
Fix manifest generate cmd.
Verifying this change
See /pkg/dubboctl/cmd/manifest_test.go