Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubboctl enhancement #1095

Merged
merged 51 commits into from
May 2, 2023
Merged

Conversation

DMwangnima
Copy link

What is the purpose of the change

Enhance dubboctl based on initial phase.

Brief changelog

Implement manifest diff and manifest uninstall.
Add some log sentences.
Fix manifest generate cmd.

Verifying this change

See /pkg/dubboctl/cmd/manifest_test.go

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #1095 (25d602e) into refactor-with-go (f3ced2e) will increase coverage by 0.41%.
The diff coverage is 69.58%.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1095      +/-   ##
====================================================
+ Coverage             59.10%   59.51%   +0.41%     
====================================================
  Files                    47       47              
  Lines                  3932     4108     +176     
====================================================
+ Hits                   2324     2445     +121     
- Misses                 1384     1421      +37     
- Partials                224      242      +18     
Impacted Files Coverage Δ
pkg/dubboctl/internal/operator/operator.go 0.00% <0.00%> (ø)
pkg/dubboctl/internal/kube/client.go 48.20% <46.15%> (-1.23%) ⬇️
pkg/dubboctl/internal/operator/component.go 62.82% <47.82%> (-1.07%) ⬇️
pkg/dubboctl/internal/util/yaml.go 50.00% <85.71%> (+50.00%) ⬆️
pkg/dubboctl/internal/kube/object.go 83.33% <96.87%> (+11.27%) ⬆️
pkg/dubboctl/cmd/manifest.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 649b5f1 into apache:refactor-with-go May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants