Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubboctl enhancement for publishing #1198

Merged

Conversation

DMwangnima
Copy link

What is the purpose of the change

This is a PR aiming to make some small fixes for publishing.
For now, it introduces the following changes:

  1. Provide Demo profile and Default profile. Demo profile would install all components and Default profile would install only Admin and Zookeeper to support basic functionality.

@codecov-commenter
Copy link

Codecov Report

Merging #1198 (a0fa371) into refactor-with-go (cf1c91b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1198      +/-   ##
====================================================
- Coverage             49.47%   49.43%   -0.04%     
====================================================
  Files                    95       95              
  Lines                  5114     5114              
  Branches                 41       41              
====================================================
- Hits                   2530     2528       -2     
- Misses                 2325     2327       +2     
  Partials                259      259              
Impacted Files Coverage Δ
dubbo-admin-ui/src/api/menu.js 0.00% <ø> (ø)
dubbo-admin-ui/src/components/ServiceDetail.vue 0.00% <ø> (ø)
dubbo-admin-ui/src/components/apiDocs/ApiForm.vue 0.00% <ø> (ø)
dubbo-admin-ui/src/components/public/AceEditor.vue 0.00% <ø> (ø)
...ubbo-admin-ui/src/components/public/Breadcrumb.vue 0.00% <ø> (ø)
dubbo-admin-ui/src/components/public/Drawer.vue 0.00% <ø> (ø)
dubbo-admin-ui/src/router/index.js 0.00% <ø> (ø)
dubbo-admin-ui/src/util/index.js 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 0d0ec46 into apache:refactor-with-go Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants