-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl: reduce syscall and memcopy for multiple package #36
Conversation
Thank your for raising your pull request. |
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 69.61% 70.22% +0.61%
==========================================
Files 7 7
Lines 1415 1404 -11
==========================================
+ Hits 985 986 +1
+ Misses 336 328 -8
+ Partials 94 90 -4
Continue to review full report at Codecov.
|
LGTM |
|
connection.go
Outdated
return length, perrors.WithStack(err) | ||
} | ||
|
||
return 0, perrors.Errorf("illegal @pkg{%#v} type", pkg) | ||
//return length, err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete unuseful line ?
@watermelo Can |
直接中文回复你吧。从功能上讲,你的理解当然是对的,但是基于这两个函数都是 public 的,所以基于最小改动原则,个人建议不合并。 |
@AlexStocks @watermelo 嗯,是的。还有一个小小的问题,就是 https://github.com/dubbogo/getty/blob/8b02420a4bc8f7928b22ccf6fb1caaecab5b2e8e/session.go#L431-L439 是不是需要放到下面的用 这样看起来是不是统一点? |
@gaoxinge done |
@watermelo Great job! LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mod: remove useless return and make runUDPEventLoop run in goroutine
origin issue AlexStocks#33