Improve/delte handle loop #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
approved these changes
Jun 19, 2021
wongoo
reviewed
Jun 19, 2021
benchmark/client/main.go
Outdated
| _, _, err := Session.WritePkg(msg, WritePkgTimeout) | ||
| if err != nil { | ||
| log.Printf("Err:session.WritePkg(session{%s}, error{%v}", Session.Stat(), err) | ||
| Session.Close() |
There was a problem hiding this comment.
should it create new session if error happens？
|
@georgehao pls fix ci. |
压测表现：系统：CentOS Linux release 7.5.1804 (Core) 压测参数解释./client -ip xx:8090 -c 100 -n 100000 -c ： 启动客户端数量 旧版本gettygetty: v1.4.3
新版本getty
|
…-getty into improve/delte-handleLoop
AlexStocks
approved these changes
Jun 22, 2021
Codecov Report
@@ Coverage Diff @@
## improve/delte-handleLoop #61 +/- ##
=========================================================
Coverage 66.74% 66.74%
=========================================================
Files 8 8
Lines 1260 1260
=========================================================
Hits 841 841
Misses 326 326
Partials 93 93
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Jun 23, 2021
xiaoliu10
approved these changes
Jun 27, 2021
Mulavar
approved these changes
Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: