Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dubbo version #130

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Fix: dubbo version #130

merged 2 commits into from
Sep 9, 2019

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

Keep consistent with Java for response attachments.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@wongoo
Copy link
Contributor

wongoo commented Sep 9, 2019

@fangyincheng pls review

@fangyincheng
Copy link
Contributor Author

@fangyincheng pls review

@AlexStocks

@AlexStocks
Copy link
Contributor

@fangyincheng pls review

@AlexStocks

I have no other questions. But, you should put the dubbo source code file on DUBBO_VERSION as comment.

@AlexStocks AlexStocks merged commit 80cbb25 into apache:master Sep 9, 2019
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants