Imp: cache in reflection #179

micln · 2020-04-11T06:50:04Z

What this PR does:

Which issue(s) this PR fixes:

Fixes #169

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

micln · 2020-04-11T06:52:12Z

why cache in findField ?

$ go test -benchmem -run=^$ github.com/apache/dubbo-go-hessian2 -bench "^(BenchmarkDecode)$" -vet=off -v

before

BenchmarkDecode-8   	   61917	     18027 ns/op	    7448 B/op	     224 allocs/op

after

BenchmarkDecode-8   	   81508	     12387 ns/op	    7224 B/op	     126 allocs/op

go.mod

wongoo · 2020-04-11T07:07:00Z

great job

object.go

pojo.go

micln · 2020-04-12T12:30:59Z

go test doesn't work stable, this is a result seems average

As a whole, hessian encode/decode is performance 85% of json.Marshal/Unmarshal in cpu profiler now.

$ go test -benchmem -run=^$ github.com/apache/dubbo-go-hessian2 -bench "^B" -vet=off -v -count=5
goos: darwin
goarch: amd64
pkg: github.com/apache/dubbo-go-hessian2
BenchmarkJsonEncode
BenchmarkJsonEncode-8   	  249114	      4719 ns/op	     832 B/op	      15 allocs/op
BenchmarkJsonEncode-8   	  252224	      4862 ns/op	     832 B/op	      15 allocs/op
BenchmarkJsonEncode-8   	  240582	      4739 ns/op	     832 B/op	      15 allocs/op
BenchmarkJsonEncode-8   	  213283	      4784 ns/op	     832 B/op	      15 allocs/op
BenchmarkJsonEncode-8   	  227101	      4665 ns/op	     832 B/op	      15 allocs/op
BenchmarkEncode
BenchmarkEncode-8       	  182184	      5615 ns/op	    1771 B/op	      51 allocs/op
BenchmarkEncode-8       	  183007	      5565 ns/op	    1771 B/op	      51 allocs/op
BenchmarkEncode-8       	  218664	      5593 ns/op	    1771 B/op	      51 allocs/op
BenchmarkEncode-8       	  214704	      5886 ns/op	    1770 B/op	      51 allocs/op
BenchmarkEncode-8       	  181861	      5605 ns/op	    1770 B/op	      51 allocs/op
BenchmarkJsonDecode
BenchmarkJsonDecode-8   	  123667	      8412 ns/op	    1776 B/op	      51 allocs/op
BenchmarkJsonDecode-8   	  122796	      8497 ns/op	    1776 B/op	      51 allocs/op
BenchmarkJsonDecode-8   	  132103	      8471 ns/op	    1776 B/op	      51 allocs/op
BenchmarkJsonDecode-8   	  130687	      8492 ns/op	    1776 B/op	      51 allocs/op
BenchmarkJsonDecode-8   	  127668	      8476 ns/op	    1776 B/op	      51 allocs/op
BenchmarkDecode
BenchmarkDecode-8       	  107775	     10092 ns/op	    6424 B/op	      98 allocs/op
BenchmarkDecode-8       	  110996	      9950 ns/op	    6424 B/op	      98 allocs/op
BenchmarkDecode-8       	  111036	     10760 ns/op	    6424 B/op	      98 allocs/op
BenchmarkDecode-8       	  113151	     10063 ns/op	    6424 B/op	      98 allocs/op
BenchmarkDecode-8       	  109197	     10002 ns/op	    6424 B/op	      98 allocs/op
PASS
ok  	github.com/apache/dubbo-go-hessian2	28.680s

object.go

codecov-io · 2020-04-12T12:55:02Z

Codecov Report

Merging #179 into master will increase coverage by 0.15%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   67.42%   67.58%   +0.15%     
==========================================
  Files          22       22              
  Lines        2671     2690      +19     
==========================================
+ Hits         1801     1818      +17     
  Misses        666      666              
- Partials      204      206       +2

Impacted Files	Coverage Δ
object.go	`65.84% <86.84%> (+1.23%)`	⬆️
pojo.go	`60.54% <100.00%> (+0.43%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e7f35...5f616cd. Read the comment docs.

wongoo

LGTM

object.go

object_test.go

object.go

micln · 2020-04-18T13:52:19Z

@AlexStocks @gaoxinge any problem ?

gaoxinge · 2020-04-18T13:58:05Z

@micln Good job. LGTM.

wongoo · 2020-04-18T14:29:24Z

@ALL pls resolve conversations if already resolved, so that make sure it can be merged.

micln · 2020-04-19T04:14:16Z

@ALL pls resolve conversations if already resolved, so that make sure it can be merged.

done

object.go

AlexStocks · 2020-04-19T05:24:51Z

LGTM

object.go

gaoxinge

LGTM.

Imp: cache in reflection (apache#179)

* add license checker (#175) * add release note for v1.5.0 (#178) Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> * Imp: cache in reflection (#179) * benchmark result * use cache in findField * encode benchmark * call field() once * remove version * fix import sync * cache in registerPOJO * add json bench result * prune unneccessary rtype.Field(index) * cache comment * rename cache * switch to if * remove return value name * findFieldWithCache * remove if check when fieldStruct is nil Co-authored-by: 望哥 <gelnyang@163.com> * update dependency * rename serialize arg name * Create .asf.yaml * 优化hessian解码string性能，提升54% * optimize code. * optimize code. * fix code review. * optimize codes. * optimize cods. * optimize code. * update license * go.sum * ci go version * testify -> 1.4.0 * testcase * travis.yml * decode value before reflect find * setvalue * decode nilPtr to nilPtr * fix get attachment lost nil key * manually import package * add ToMapStringString unit test * rename test function name with issue * setmap * support for decode emoji. * refactor code * add unit test. * add unit tests. * refactor tests. * Update travis/main.sh (#200) - Remove duplicate key 'webhooks' - Key 'matrix' is an alias for `jobs`, using `jobs` - Specify the os and dist explicitly * Mod: modify * Code format (#199) * .gitignore * code clean * code clean * remove length check * Fix: comments * Fix: format package * Fix #181: float32 accuracy issue (#196) * Fix #181: float32 accuracy issue * Fix go fmt failure * Add the unit test case for Issue181 * Add encFloat32 in double.go to encode float32 type - Call encFloat32 to encode float32 while encoding - Add unit test case to test float32 encoding * Improve encFloat32 of double.go * Fix git fmt failure * add release note for v1.6.0 (#202) * add release note for v1.5.1 * add release note for v1.5.1 * add notice * update notice * =fix release note for v1.6.0 Co-authored-by: Joe Zou <joezou@apache.org> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: huiren <zhrlnt@gmail.com> Co-authored-by: Huang YunKun <htynkn@gmail.com> Co-authored-by: zonghaishang <yiji@apache.org> Co-authored-by: fangyincheng <fangyc666@gmail.com> Co-authored-by: champly <champly@outlook.com> Co-authored-by: wilson chen <willson.chenwx@gmail.com> Co-authored-by: fangyincheng <fangyincheng@sina.com> Co-authored-by: gaoxinge <gaoxx5@gmail.com>

* add license checker (#175) * add release note for v1.5.0 (#178) Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> * Imp: cache in reflection (#179) * benchmark result * use cache in findField * encode benchmark * call field() once * remove version * fix import sync * cache in registerPOJO * add json bench result * prune unneccessary rtype.Field(index) * cache comment * rename cache * switch to if * remove return value name * findFieldWithCache * remove if check when fieldStruct is nil Co-authored-by: 望哥 <gelnyang@163.com> * update dependency * rename serialize arg name * Create .asf.yaml * 优化hessian解码string性能，提升54% * optimize code. * optimize code. * fix code review. * optimize codes. * optimize cods. * optimize code. * update license * go.sum * ci go version * testify -> 1.4.0 * testcase * travis.yml * decode value before reflect find * setvalue * decode nilPtr to nilPtr * fix get attachment lost nil key * manually import package * add ToMapStringString unit test * rename test function name with issue * setmap * support for decode emoji. * refactor code * add unit test. * add unit tests. * refactor tests. * Update travis/main.sh (#200) - Remove duplicate key 'webhooks' - Key 'matrix' is an alias for `jobs`, using `jobs` - Specify the os and dist explicitly * Mod: modify * Code format (#199) * .gitignore * code clean * code clean * remove length check * Fix: comments * Fix: format package * Fix #181: float32 accuracy issue (#196) * Fix #181: float32 accuracy issue * Fix go fmt failure * Add the unit test case for Issue181 * Add encFloat32 in double.go to encode float32 type - Call encFloat32 to encode float32 while encoding - Add unit test case to test float32 encoding * Improve encFloat32 of double.go * Fix git fmt failure * add release note for v1.6.0 (#202) * add release note for v1.5.1 * add release note for v1.5.1 * add notice * update notice * =fix release note for v1.6.0 * Fix: eunm encode in request get error (#203) * fix bug: eunm encode in request get error * fix mod * add ut * remove go.mod 1.13 to fix the ci Co-authored-by: Joe Zou <joezou@apache.org> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: huiren <zhrlnt@gmail.com> Co-authored-by: Huang YunKun <htynkn@gmail.com> Co-authored-by: zonghaishang <yiji@apache.org> Co-authored-by: fangyincheng <fangyc666@gmail.com> Co-authored-by: champly <champly@outlook.com> Co-authored-by: wilson chen <willson.chenwx@gmail.com> Co-authored-by: fangyincheng <fangyincheng@sina.com> Co-authored-by: gaoxinge <gaoxx5@gmail.com> Co-authored-by: panty <pantianying@gmail.com>

* benchmark result * use cache in findField * encode benchmark * call field() once * remove version * fix import sync * cache in registerPOJO * add json bench result * prune unneccessary rtype.Field(index) * cache comment * rename cache * switch to if * remove return value name * findFieldWithCache * remove if check when fieldStruct is nil Co-authored-by: 望哥 <gelnyang@163.com>

* add license checker (#175) * add release note for v1.5.0 (#178) Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> * Imp: cache in reflection (#179) * benchmark result * use cache in findField * encode benchmark * call field() once * remove version * fix import sync * cache in registerPOJO * add json bench result * prune unneccessary rtype.Field(index) * cache comment * rename cache * switch to if * remove return value name * findFieldWithCache * remove if check when fieldStruct is nil Co-authored-by: 望哥 <gelnyang@163.com> * update dependency * rename serialize arg name * Create .asf.yaml * 优化hessian解码string性能，提升54% * optimize code. * optimize code. * fix code review. * optimize codes. * optimize cods. * optimize code. * update license * go.sum * ci go version * testify -> 1.4.0 * testcase * travis.yml * decode value before reflect find * setvalue * decode nilPtr to nilPtr * fix get attachment lost nil key * manually import package * add ToMapStringString unit test * rename test function name with issue * setmap * support for decode emoji. * refactor code * add unit test. * add unit tests. * refactor tests. * Update travis/main.sh (#200) - Remove duplicate key 'webhooks' - Key 'matrix' is an alias for `jobs`, using `jobs` - Specify the os and dist explicitly * Mod: modify * Code format (#199) * .gitignore * code clean * code clean * remove length check * Fix: comments * Fix: format package * Fix #181: float32 accuracy issue (#196) * Fix #181: float32 accuracy issue * Fix go fmt failure * Add the unit test case for Issue181 * Add encFloat32 in double.go to encode float32 type - Call encFloat32 to encode float32 while encoding - Add unit test case to test float32 encoding * Improve encFloat32 of double.go * Fix git fmt failure * add release note for v1.6.0 (#202) * add release note for v1.5.1 * add release note for v1.5.1 * add notice * update notice * =fix release note for v1.6.0 Co-authored-by: Joe Zou <joezou@apache.org> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: huiren <zhrlnt@gmail.com> Co-authored-by: Huang YunKun <htynkn@gmail.com> Co-authored-by: zonghaishang <yiji@apache.org> Co-authored-by: fangyincheng <fangyc666@gmail.com> Co-authored-by: champly <champly@outlook.com> Co-authored-by: wilson chen <willson.chenwx@gmail.com> Co-authored-by: fangyincheng <fangyincheng@sina.com> Co-authored-by: gaoxinge <gaoxx5@gmail.com>

micln added 2 commits April 11, 2020 14:46

benchmark result

d181b99

use cache in findField

826e986

encode benchmark

c177e97

wongoo reviewed Apr 11, 2020

View reviewed changes

go.mod Outdated Show resolved Hide resolved

call field() once

9a13b69

micln commented Apr 11, 2020

View reviewed changes

object.go Show resolved Hide resolved

remove version

3c3cb18

micln commented Apr 11, 2020

View reviewed changes

object.go Show resolved Hide resolved

micln changed the title ~~cache in decode reflection~~ cache in reflection Apr 11, 2020

fix import sync

cda3dc3

micln marked this pull request as draft April 11, 2020 07:17

cache in registerPOJO

72e3dcf

micln commented Apr 11, 2020

View reviewed changes

pojo.go Show resolved Hide resolved

AlexStocks approved these changes Apr 12, 2020

View reviewed changes

micln added 2 commits April 12, 2020 20:14

add json bench result

5ffbcda

prune unneccessary rtype.Field(index)

d8652c2

micln marked this pull request as ready for review April 12, 2020 12:31

micln commented Apr 12, 2020

View reviewed changes

object.go Show resolved Hide resolved

cache comment

fdb4f93

micln requested review from wongoo and AlexStocks April 12, 2020 14:03

wongoo approved these changes Apr 13, 2020

View reviewed changes

AlexStocks reviewed Apr 13, 2020

View reviewed changes

object.go Outdated Show resolved Hide resolved

gaoxinge reviewed Apr 14, 2020

View reviewed changes

object_test.go Show resolved Hide resolved

object.go Outdated Show resolved Hide resolved

object.go Show resolved Hide resolved

micln added 2 commits April 18, 2020 14:47

rename cache

dbfaf1f

switch to if

1baeb66

AlexStocks reviewed Apr 19, 2020

View reviewed changes

object.go Outdated Show resolved Hide resolved

micln added 2 commits April 19, 2020 12:50

remove return value name

cee2870

findFieldWithCache

5f616cd

AlexStocks approved these changes Apr 19, 2020

View reviewed changes

AlexStocks changed the title ~~cache in reflection~~ Imp: cache in reflection Apr 19, 2020

wongoo reviewed Apr 20, 2020

View reviewed changes

object.go Outdated Show resolved Hide resolved

gaoxinge approved these changes Apr 20, 2020

View reviewed changes

remove if check when fieldStruct is nil

a8e8d0f

wongoo merged commit bb036e6 into apache:master Apr 20, 2020

pantianying added a commit to pantianying/dubbo-go-hessian2 that referenced this pull request Apr 21, 2020

Merge pull request #16 from apache/master

72def95

Imp: cache in reflection (apache#179)

yf2008 mentioned this pull request May 4, 2020

记一次对 dubbo-go-hessian2 的性能优化 yf2008/duty-machine#16

Closed

wongoo mentioned this pull request Sep 6, 2020

changes for v1.7.0 from v1.6.0 #226

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Imp: cache in reflection #179

Imp: cache in reflection #179

micln commented Apr 11, 2020

micln commented Apr 11, 2020

wongoo commented Apr 11, 2020

micln commented Apr 12, 2020

codecov-io commented Apr 12, 2020 •

edited

Loading

wongoo left a comment

micln commented Apr 18, 2020

gaoxinge commented Apr 18, 2020

wongoo commented Apr 18, 2020

micln commented Apr 19, 2020

AlexStocks commented Apr 19, 2020

gaoxinge left a comment

Imp: cache in reflection #179

Imp: cache in reflection #179

Conversation

micln commented Apr 11, 2020

micln commented Apr 11, 2020

wongoo commented Apr 11, 2020

micln commented Apr 12, 2020

codecov-io commented Apr 12, 2020 • edited Loading

Codecov Report

wongoo left a comment

Choose a reason for hiding this comment

micln commented Apr 18, 2020

gaoxinge commented Apr 18, 2020

wongoo commented Apr 18, 2020

micln commented Apr 19, 2020

AlexStocks commented Apr 19, 2020

gaoxinge left a comment

Choose a reason for hiding this comment

codecov-io commented Apr 12, 2020 •

edited

Loading