Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty slice encode/decode error #340 #341

merged 2 commits into from Dec 6, 2022


Copy link

@tiltwind tiltwind commented Dec 4, 2022

Which issue(s) this PR fixes:

Fixes #340

Copy link

Codecov Report

Merging #341 (97fab4f) into master (e579dda) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #341   +/-   ##
  Coverage   72.17%   72.18%           
  Files          27       27           
  Lines        3127     3128    +1     
+ Hits         2257     2258    +1     
  Misses        633      633           
  Partials      237      237           
Impacted Files Coverage Δ
ref.go 84.21% <100.00%> (+0.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wongoo wongoo merged commit 6455362 into apache:master Dec 6, 2022
2 checks passed
@tiltwind tiltwind changed the title fix issue #340 fix empty slice encode/decode error #340 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

when a struct has more than one kind of empty slice whose type is pointer ,decode will panic
4 participants