Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving param types into parameter configuration instead of standalone… #161

Merged
merged 5 commits into from
May 20, 2021

Conversation

williamfeng323
Copy link
Contributor

@williamfeng323 williamfeng323 commented Apr 27, 2021

… config

What this PR does:

  1. Removed mappingParams configuration from API_config.
  2. Simplified the configuration of option config
  3. Removed replace_path_filter which is unnecessary.
    Which issue(s) this PR fixes:

Fixes #76 #82

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

https://github.com/dubbogo/dubbo-go-pixiu-filter/pull/8

@williamfeng323 williamfeng323 force-pushed the feature/remove-paramTypes branch 4 times, most recently from f488029 to 1aeb583 Compare April 27, 2021 13:53
Signed-off-by: william feng <williamfeng323@hotmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2021

Codecov Report

Merging #161 (213f993) into develop (c5f9fc4) will increase coverage by 1.68%.
The diff coverage is 61.68%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #161      +/-   ##
===========================================
+ Coverage    40.60%   42.28%   +1.68%     
===========================================
  Files           35       33       -2     
  Lines         1692     1743      +51     
===========================================
+ Hits           687      737      +50     
- Misses         903      905       +2     
+ Partials       102      101       -1     
Impacted Files Coverage Δ
pkg/pixiu/listener.go 19.79% <ø> (+0.40%) ⬆️
pkg/client/dubbo/dubbo.go 20.95% <30.76%> (-1.07%) ⬇️
pkg/client/http/mapper.go 70.29% <50.00%> (+1.98%) ⬆️
pkg/client/dubbo/option.go 50.58% <53.94%> (+50.58%) ⬆️
pkg/client/dubbo/mapper.go 65.41% <79.66%> (+14.15%) ⬆️
pkg/client/http/http.go 47.61% <0.00%> (-12.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f9fc4...213f993. Read the comment docs.

@xiaoliu10 xiaoliu10 merged commit c1880a3 into apache:develop May 20, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
#161)

* moving param types into parameter configuration instead of standalone config

* remve replace path filter

Signed-off-by: william feng <williamfeng323@hotmail.com>

* fix reviewdog comment
Former-commit-id: c1880a3
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
apache#161)

* moving param types into parameter configuration instead of standalone config

* remve replace path filter

Signed-off-by: william feng <williamfeng323@hotmail.com>

* fix reviewdog comment
Former-commit-id: e249bd2 [formerly c1880a3]
Former-commit-id: c452389
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
apache#161)

* moving param types into parameter configuration instead of standalone config

* remve replace path filter

Signed-off-by: william feng <williamfeng323@hotmail.com>

* fix reviewdog comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lost the origin URL path in filter.
5 participants