Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: cors policy implement #249

Merged
merged 8 commits into from
Sep 18, 2021
Merged

Conversation

MasterKenway
Copy link
Contributor

@MasterKenway MasterKenway commented Sep 8, 2021

  • Implement cors policy defined in the HttpConnectionManage

  • Style unified

@MasterKenway MasterKenway changed the title Feat: cors policy implement Feat: cors policy implement Sep 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #249 (bafddfb) into develop (efae1be) will not change coverage.
The diff coverage is 33.84%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #249   +/-   ##
========================================
  Coverage    40.93%   40.93%           
========================================
  Files           51       51           
  Lines         2587     2587           
========================================
  Hits          1059     1059           
  Misses        1415     1415           
  Partials       113      113           
Impacted Files Coverage Δ
pkg/common/extension/filter/filter_manager.go 58.82% <0.00%> (ø)
pkg/context/http/context.go 6.81% <ø> (ø)
pkg/filter/response/response.go 34.17% <0.00%> (ø)
pkg/server/http.go 0.00% <0.00%> (ø)
pkg/server/listener.go 0.00% <0.00%> (ø)
pkg/filter/accesslog/access_log.go 6.15% <16.66%> (ø)
pkg/filter/host/host.go 43.75% <28.57%> (ø)
pkg/filter/metric/metric.go 64.70% <37.50%> (ø)
pkg/filter/recovery/recovery.go 56.52% <42.85%> (ø)
pkg/filter/header/header.go 66.66% <50.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efae1be...bafddfb. Read the comment docs.

@MasterKenway MasterKenway force-pushed the feat/cors-control branch 4 times, most recently from 370295a to 9f7b749 Compare September 8, 2021 16:32
@MasterKenway MasterKenway force-pushed the feat/cors-control branch 5 times, most recently from 04318dc to 9f7b749 Compare September 11, 2021 08:27
@mark4z
Copy link
Member

mark4z commented Sep 18, 2021

LGTM

@mark4z mark4z merged commit f1836e0 into apache:develop Sep 18, 2021
@ztelur ztelur added this to the v0.4.0 milestone Oct 20, 2021
mark4z added a commit that referenced this pull request Nov 7, 2021
Feat: cors policy implement
Former-commit-id: f1836e0
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
Feat: cors policy implement
Former-commit-id: 47589e2 [formerly f1836e0]
Former-commit-id: 8325018
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants