add trie for route #262
Merged
add trie for route #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 30, 2021 20:10
AlexStocks
reviewed
Oct 1, 2021
AlexStocks
reviewed
Oct 1, 2021
AlexStocks
reviewed
Oct 1, 2021
|
IMPORT 使用规范，请教下其他同学。 代码中不要出现中文注释。 |
|
Resolve conflicts pls |
MasterKenway
reviewed
Oct 3, 2021
Comment on lines
+46
to
+52
|
|
||
| const ( | ||
| Get = "GET" | ||
| Put = "PUT" | ||
| Post = "POST" | ||
| Delete = "DELETE" | ||
| ) |
There was a problem hiding this comment.
What about using constant defined in the net/http?
AlexStocks
reviewed
Oct 8, 2021
MasterKenway
approved these changes
Oct 8, 2021
AlexStocks
reviewed
Oct 9, 2021
ztelur
approved these changes
Oct 21, 2021
|
The impots format problem can be solved with the tools |
|
Feat/trie
remove chinese and fix reviewdog issues
mark4z
approved these changes
Nov 24, 2021
| key = getTrieKey(method, r.Match.Path, isPrefix) | ||
| } | ||
| rm.activeConfig.RouteTrie.Put(key, r.Route) | ||
| } |
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
* add trie for route * bug fix * bug fix * merge master * add assert for params * add assert for params * a/b should match prefix:a/b * a/b should match prefix:a/b * a/b should match prefix:a/b * a/b should match prefix:a/b * a/b should match prefix:a/b * a/b should match prefix:a/b * merge with master * merge with master * merge with master * merge with master * merge with master * merge with master * merge with master * review dog * review dog * review dog * review dog * review dog * add note * add note * add note * add note * remove chinese * update * remove chinese and fix reviewdog issues Co-authored-by: yangqing.xyq <yangqing.xyq@gongdao.com> Co-authored-by: Mark4z <36187602+mark4z@users.noreply.github.com> Co-authored-by: zhangxun <18721825717@163.com> Co-authored-by: Randy <ztelur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: add trie struct for route request to matched filter
Does this PR introduce a user-facing change?: remove head match for request