Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nacos config #497

Merged
merged 14 commits into from
Oct 31, 2022
Merged

Feature/nacos config #497

merged 14 commits into from
Oct 31, 2022

Conversation

PhilYue
Copy link
Member

@PhilYue PhilYue commented Sep 17, 2022

What this PR does:
Load bootstrap config from config center of Nacos.

  • load boot config initialize

Feat V2 TODO :

  • [-] TODO load log config from config center
  • [-] listener does not support

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@PhilYue PhilYue added this to the 0.6.0 milestone Sep 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2022

Codecov Report

Merging #497 (b71ac6e) into develop (b71ac6e) will not change coverage.
The diff coverage is n/a.

❗ Current head b71ac6e differs from pull request most recent head d9c51c2. Consider uploading reports for the commit d9c51c2 to get more accurate results

@@           Coverage Diff            @@
##           develop     #497   +/-   ##
========================================
  Coverage    54.73%   54.73%           
========================================
  Files          666      666           
  Lines        77905    77905           
========================================
  Hits         42638    42638           
  Misses       31635    31635           
  Partials      3632     3632           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zgq25302111
Copy link
Contributor

RFC

@mark4z
Copy link
Member

mark4z commented Oct 8, 2022

update go mod

@PhilYue PhilYue requested review from mark4z and ztelur October 16, 2022 11:39
@zgq25302111
Copy link
Contributor

没有 merge 的代码,如何批量把变动的代码 download 呢

@mark4z
Copy link
Member

mark4z commented Oct 27, 2022

没有 merge 的代码,如何批量把变动的代码 download 呢

语雀里有如何修改别人的代码这么一篇文章

@zgq25302111
Copy link
Contributor

没有 merge 的代码,如何批量把变动的代码 download 呢

语雀里有如何修改别人的代码这么一篇文章

还记得访问地址吗?

DataId string
Group string
path string
parser string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this.

@mark4z mark4z merged commit bca3213 into apache:develop Oct 31, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
* uddapte: nacos config

* Add: nacos config center

* update: nacos config

* add ut

* fmt

* clean code for CI

* update: listen

* Add go sum

* update: fix config_center UT, ignore the cache and log dir

* fix UT

* update: off nacos_config_center UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants