OSPP: Traffic Distribution #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baerwang
reviewed
Oct 2, 2022
maxingg
force-pushed
the
feature/traffic
branch
from
118be46
to
964afa3
Compare
baerwang
approved these changes
Oct 10, 2022
maxingg
force-pushed
the
feature/traffic
branch
from
964afa3
to
f7da3cf
Compare
PhilYue
reviewed
Oct 10, 2022
| res = spiltWeight(f.weight, c.weightFloor, c.weightCeil) | ||
| } | ||
| return res | ||
| return spiltWeight(f.weight, c.weightFloor, c.weightCeil) | ||
| } | ||
|
|
||
| func (factory *FilterFactory) rulesMatch(f *Filter, path string) []*ClusterWrapper { |
There was a problem hiding this comment.
想了解一下这个path 和 cluster.Router 是如何匹配上的，有没有具体的例子可以描述一下 ，比如 path="/xxx/xx"， cluster.Router = "/xxx"
There was a problem hiding this comment.
看下这个pr: apache/dubbo-go-pixiu-samples#7
|
突然想到一个问题，把这些配置计算到md5，然后获取reqeust的相关信息计算md5去找到对应的cluster这样效率会快很多呀 |
初始化先把配置md5计算好 |
PhilYue
approved these changes
Oct 16, 2022
bobtthp
approved these changes
Oct 17, 2022
AlbumenJ
approved these changes
Oct 17, 2022
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Update Traffic Filter to pass all Tests.
Which issue(s) this PR fixes:
Fixes #402