Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sample url using https://github.com/apache/dubbo-go-pixiu-samples… #506

Merged
merged 4 commits into from
Oct 30, 2022

Conversation

ma642
Copy link
Contributor

@ma642 ma642 commented Oct 23, 2022

….git

What this PR does: fix sample url using https://github.com/apache/dubbo-go-pixiu-samples…

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE


@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Merging #506 (d9a7a0f) into develop (b71ac6e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #506      +/-   ##
===========================================
+ Coverage    54.73%   54.74%   +0.01%     
===========================================
  Files          666      664       -2     
  Lines        77905    77746     -159     
===========================================
- Hits         42638    42559      -79     
+ Misses       31635    31555      -80     
  Partials      3632     3632              
Impacted Files Coverage Δ
security/pkg/credentialfetcher/fetcher.go 40.00% <0.00%> (-20.00%) ⬇️
pkg/istio-agent/xds_proxy_delta.go 45.59% <0.00%> (-6.74%) ⬇️
pkg/test/framework/resource/version.go 18.42% <0.00%> (-1.76%) ⬇️
pilot/pkg/bootstrap/certcontroller.go 42.51% <0.00%> (-1.20%) ⬇️
pilot/pkg/model/service.go 46.60% <0.00%> (-0.91%) ⬇️
pilot/pkg/model/jwks_resolver.go 78.29% <0.00%> (-0.78%) ⬇️
security/pkg/nodeagent/cache/secretcache.go 84.94% <0.00%> (-0.77%) ⬇️
pixiu/pkg/server/pixiu_start.go 3.22% <0.00%> (-0.73%) ⬇️
pilot/pkg/bootstrap/server.go 53.11% <0.00%> (-0.46%) ⬇️
pkg/istio-agent/xds_proxy.go 61.17% <0.00%> (-0.44%) ⬇️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mark4z mark4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 2bf73ec into apache:develop Oct 30, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
apache#506)

* fix sample url using https://github.com/apache/dubbo-go-pixiu-samples.git

* donot replace pixiu/pkg

* samples always run under dubbo-go-pixiu/integrate_test

* fix CI issue

Co-authored-by: mazhihui <mazhihui@baimaohui.net>
@mark4z mark4z added this to the v1.0.0 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants