Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:register hashing and array out of bounds and init hashing #530

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

baerwang
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #530 (86a2628) into develop (9db643e) will decrease coverage by 0.46%.
The diff coverage is 57.89%.

@@             Coverage Diff             @@
##           develop     #530      +/-   ##
===========================================
- Coverage    55.13%   54.67%   -0.47%     
===========================================
  Files          667      666       -1     
  Lines        79061    77878    -1183     
===========================================
- Hits         43590    42576    -1014     
+ Misses       31784    31659     -125     
+ Partials      3687     3643      -44     
Impacted Files Coverage Δ
pixiu/pkg/context/http/context.go 0.00% <0.00%> (ø)
pixiu/pkg/server/cluster_manager.go 36.84% <60.00%> (ø)
...u/pkg/cluster/loadbalancer/hash/consistent_hash.go 66.66% <70.00%> (-3.34%) ⬇️
pixiu/pkg/filter/accesslog/access_log.go 55.07% <100.00%> (+0.66%) ⬆️
security/pkg/credentialfetcher/fetcher.go 40.00% <0.00%> (-20.00%) ⬇️
pilot/pkg/bootstrap/server.go 53.11% <0.00%> (-9.71%) ⬇️
pkg/envoy/admin.go 50.00% <0.00%> (-9.68%) ⬇️
pkg/istio-agent/xds_proxy_delta.go 45.07% <0.00%> (-8.81%) ⬇️
pilot/pkg/model/push_context.go 58.10% <0.00%> (-4.74%) ⬇️
pilot/pkg/model/addressmap.go 63.23% <0.00%> (-4.42%) ⬇️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mark4z mark4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark4z
Copy link
Member

mark4z commented Dec 6, 2022

fix ci pls

@baerwang baerwang force-pushed the fix-hashing branch 2 times, most recently from 9e22bee to c47930b Compare December 18, 2022 13:16
@sonarcloud
Copy link

sonarcloud bot commented Dec 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexStocks AlexStocks merged commit 484f451 into apache:develop Jan 6, 2023
@mark4z mark4z added this to the v1.0.0 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants