Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix triple proxy problems #548

Merged
merged 10 commits into from
Mar 21, 2023
Merged

Fix triple proxy problems #548

merged 10 commits into from
Mar 21, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Feb 25, 2023 •
edited
Loading

Fix the problems in Triple Proxy.

Tasklist:

  • Remove the grpc-http-proxy module
  • Enable to forward the header of triple request
  • Add protoset file support in proxy

Relative issues: #525 #523

@shawnh2 shawnh2 changed the title [WIP] Fix the problems in triple proxy Add adility to forward the header within triple request Mar 4, 2023
@AlexStocks AlexStocks requested a review from mark4z March 5, 2023 12:35
@shawnh2 shawnh2 changed the title Add adility to forward the header within triple request Fix triple proxy problems Mar 7, 2023
@mark4z
Copy link
Member

mark4z commented Mar 12, 2023

Nice job

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2023 •
edited
Loading

Codecov Report

Merging #548 (5c07368) into develop (e8d9881) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 5c07368 differs from pull request most recent head e354aaf. Consider uploading reports for the commit e354aaf to get more accurate results

@@             Coverage Diff             @@
##           develop     #548      +/-   ##
===========================================
- Coverage    54.68%   54.65%   -0.04%     
===========================================
  Files          666      666              
  Lines        77881    77881              
===========================================
- Hits         42589    42564      -25     
- Misses       31651    31676      +25     
  Partials      3641     3641

see 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mark4z
mark4z requested changes Mar 19, 2023
View reviewed changes
pixiu/pkg/client/triple/triple.go Outdated Show resolved Hide resolved
pixiu/pkg/client/triple/triple.go Outdated Show resolved Hide resolved
pixiu/pkg/client/proxy/descriptor_source.go Show resolved Hide resolved
@mark4z
Copy link
Member

mark4z commented Mar 19, 2023

nice job

@sonarcloud
Copy link

sonarcloud bot commented Mar 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawnh2 shawnh2 requested a review from mark4z March 19, 2023 07:51
@AlexStocks AlexStocks merged commit d25b697 into apache:develop Mar 21, 2023
@shawnh2 shawnh2 deleted the triple-proxy branch March 21, 2023 02:47
This was referenced Apr 2, 2023
Closed
Closed
@mark4z mark4z mentioned this pull request Jun 19, 2023
Closed
@mark4z mark4z added this to the v1.0.0 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark4z mark4z mark4z approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shawnh2 @mark4z @codecov-commenter @AlexStocks