Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go version to v1.17 #2221

Merged
merged 1 commit into from
Feb 23, 2023
Merged

upgrade go version to v1.17 #2221

merged 1 commit into from
Feb 23, 2023

Conversation

tiltwind
Copy link
Contributor

@tiltwind tiltwind commented Feb 21, 2023

What this PR does:
upgrade go version from v1.15 to v1.17
There are some new apis like time.UnixMilli() from v1.17, which may be used in other relative projects, see here.

Now , the latest version of golang is v1.20, and golang is also forward compatible, I think we can upgrade to v1.17 first.

Which issue(s) this PR fixes:
None

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2221 (01ce415) into 3.0 (e284dbf) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 01ce415 differs from pull request most recent head 0a1a251. Consider uploading reports for the commit 0a1a251 to get more accurate results

@@            Coverage Diff             @@
##              3.0    #2221      +/-   ##
==========================================
+ Coverage   44.13%   44.16%   +0.02%     
==========================================
  Files         283      283              
  Lines       17172    17172              
==========================================
+ Hits         7579     7584       +5     
+ Misses       8798     8790       -8     
- Partials      795      798       +3     
Impacted Files Coverage Δ
cluster/loadbalance/ringhash/ring.go 84.50% <0.00%> (-2.82%) ⬇️
metrics/prometheus/reporter.go 30.37% <0.00%> (+3.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlexStocks AlexStocks merged commit aed1287 into apache:3.0 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants