Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: Opentracing & Transfer context end2end with jsonrpc protocol #335

Merged
merged 15 commits into from
Jan 23, 2020

Conversation

flycash
Copy link
Member

@flycash flycash commented Jan 21, 2020

What this PR does:

Now we will use the opentracing to trace our framework.

image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
This PR only resolve the problem of transferring context between client and server with jsonrpc protocol;
What we need to do is to support transfer context with grpc protocol and dubbo protocol.

Another consideration is that we need to check our code to see whether we need to create more span to trace the invocation.

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@37d517e). Click here to learn what that means.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #335   +/-   ##
=========================================
  Coverage           ?   65.6%           
=========================================
  Files              ?     123           
  Lines              ?    7605           
  Branches           ?       0           
=========================================
  Hits               ?    4989           
  Misses             ?    2123           
  Partials           ?     493
Impacted Files Coverage Δ
cluster/cluster_impl/broadcast_cluster_invoker.go 80% <ø> (ø)
protocol/invoker.go 0% <ø> (ø)
filter/filter_impl/echo_filter.go 85.71% <ø> (ø)
...ter/cluster_impl/registry_aware_cluster_invoker.go 75% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 71.42% <ø> (ø)
cluster/cluster_impl/failsafe_cluster_invoker.go 81.81% <ø> (ø)
filter/filter_impl/tps_limit_filter.go 88.23% <ø> (ø)
common/proxy/proxy_factory/default.go 20.96% <0%> (ø)
protocol/jsonrpc/http.go 75% <0%> (ø)
protocol/jsonrpc/server.go 59.61% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d517e...0196c0e. Read the comment docs.

@AlexStocks AlexStocks merged commit d9075ad into apache:develop Jan 23, 2020
@flycash flycash mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants